[C++ API] Fix Module::zero_grad #8964
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goldsborough
requested review from
apaszke,
colesbury,
ebetica,
ezyang,
gchanan,
soumith and
zdevito
as code owners
|
@pytorchbot retest this please |
ezyang
approved these changes
Jun 28, 2018
There was a problem hiding this comment.
@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: `nn::Module::zero_grad` did not respect undefined `grad()` variables. This is fixed (the code now replicates PyTorch). ebetica ezyang apaszke Closes pytorch#8964 Reviewed By: ezyang Differential Revision: D8677529 Pulled By: goldsborough fbshipit-source-id: afdc4ba00dbf5012c37d1f794c731937ee5e422e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nn::Module::zero_graddid not respect undefinedgrad()variables. This is fixed (the code now replicates PyTorch).@ebetica @ezyang @apaszke