Skip to content

Conversation

@mlazos
Copy link
Contributor

@mlazos mlazos commented Nov 29, 2022

@mlazos mlazos requested a review from anijain2305 November 29, 2022 08:41
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 29, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/89828

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 4 Pending

As of commit 8fe2d96:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@anijain2305
Copy link
Contributor

cc @Chillee

I think we should also add a config. And this env flag can be used to setup that config.

Copy link
Contributor

@anijain2305 anijain2305 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test?

Maybe adding a compiler and using CompileCounter to test num of graphs is 0 after setting that config off.

@mlazos mlazos changed the title add env flag to disable dynamo from the commandline add env/config flag to disable dynamo Nov 29, 2022
@mlazos
Copy link
Contributor Author

mlazos commented Nov 29, 2022

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 29, 2022
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@github-actions github-actions bot deleted the mlazos/disable-flag branch May 31, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants