Skip to content

[LTC] Remove noop_execution_mode_ #89989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Parent: Add extra debug info for the super common "index out of bounds" error.
wants to merge 1 commit into from
Closed

[LTC] Remove noop_execution_mode_ #89989

wants to merge 1 commit into from

Conversation

@alanwaketan
Copy link
Collaborator

Summary:
noop_execution_mode_ doesn't seem to be useful anymore. Let's remove it.

Test Plan:
CI.

@alanwaketan
[LTC] Remove noop_execution_mode_
07c29f1 
Summary:
noop_execution_mode_ doesn't seem to be useful anymore. Let's remove it.

Test Plan:
CI.
@alanwaketan alanwaketan requested a review from JackCaoG December 1, 2022 04:12
@alanwaketan alanwaketan self-assigned this Dec 1, 2022
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 1, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/89989

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 07c29f1:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@dagitses dagitses requested a review from desertfire December 1, 2022 15:22
@dagitses dagitses added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Dec 1, 2022
desertfire
desertfire approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@desertfire desertfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alanwaketan
Copy link
Collaborator Author

Thanks, Bin.

@alanwaketan
Copy link
Collaborator Author

@pytorchbot merge -g

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 1, 2022
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 additional jobs have failed, first few of them are: trunk

Details for Dev Infra team Raised by workflow job

@alanwaketan
Copy link
Collaborator Author

@pytorchbot merge -f "tests are timed out but shouldn't be related."

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@alanwaketan @kulinseth
[LTC] Remove noop_execution_mode_ (pytorch#89989)
38d0da1 
Summary:
noop_execution_mode_ doesn't seem to be useful anymore. Let's remove it.

Test Plan:
CI.

Pull Request resolved: pytorch#89989
Approved by: https://github.com/desertfire, https://github.com/JackCaoG
@github-actions github-actions bot deleted the alanwaketan/noop branch June 1, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@desertfire desertfire desertfire approved these changes

@JackCaoG JackCaoG JackCaoG approved these changes

Assignees

@alanwaketan alanwaketan

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: lazy open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alanwaketan @pytorchmergebot @desertfire @JackCaoG @dagitses