Skip to content

triton supports devices < 7.0, not 6.0 #90020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Parent: Add extra debug info for the super common "index out of bounds" error.
wants to merge 1 commit into from
Closed

triton supports devices < 7.0, not 6.0 #90020

wants to merge 1 commit into from

Conversation

@soumith
Copy link
Member

@soumith soumith commented Dec 1, 2022 •
edited by pytorch-bot bot
Loading

triton is still buggy with Pascal devices, so make the error checker reflect that.

Also, this < 6.0 never worked, as the has_triton definition in utils.py was checking >= 7.0.

cc @mlazos @voznesenskym @yanboliang @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @chunyuan-w @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @desertfire

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 1, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/90020

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit 61bbc04:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@soumith soumith added the topic: not user facing topic category label Dec 1, 2022
@soumith
Copy link
Member Author

soumith commented Dec 1, 2022

@pytorchbot merge -f "need to make sure this is in the nightlies tonight"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Approval needed from one of the following (Rule 'superuser'):
c-odrin, teytaud, wz337, clee2000, vtsyvina, ...

Details for Dev Infra team Raised by workflow job

@anijain2305
Copy link
Contributor

@pytorchbot merge -f "need to make sure this is in the nightlies tonight"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@soumith @kulinseth
triton supports devices < 7.0, not 6.0 (pytorch#90020)
5b36869 
triton is still buggy with Pascal devices, so make the error checker reflect that.

Also, this < 6.0 never worked, as the `has_triton` definition in utils.py was checking >= 7.0.

Pull Request resolved: pytorch#90020
Approved by: https://github.com/yanboliang, https://github.com/anijain2305
@github-actions github-actions bot deleted the triton_pascal_disable branch June 2, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anijain2305 anijain2305 anijain2305 approved these changes

+1 more reviewer

@yanboliang yanboliang yanboliang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/inductor Merged module: inductor topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@soumith @pytorchmergebot @anijain2305 @yanboliang