Skip to content

skip flaky tests (rather than expectedFailure) #90233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

skip flaky tests (rather than expectedFailure) #90233

wants to merge 1 commit into from

Conversation

ppwwyyxx
Copy link
Collaborator

@ppwwyyxx ppwwyyxx commented Dec 5, 2022

They are flaky but don't always fail. So expectedFailure is incorrect.

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 5, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/90233

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 81a286f:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: python_frontend python frontend release notes category label Dec 5, 2022
mruberry
mruberry approved these changes Dec 6, 2022
View reviewed changes
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@mruberry
Copy link
Collaborator

mruberry commented Dec 6, 2022

@pytorchbot merge -g

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 6, 2022
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: The following mandatory check(s) failed (Rule Core Reviewers):

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

@mruberry
Copy link
Collaborator

mruberry commented Dec 6, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: The following mandatory check(s) failed (Rule Core Reviewers):

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

@soumith
Copy link
Member

soumith commented Dec 8, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: The following mandatory check(s) failed (Rule superuser):

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

@soumith
Copy link
Member

soumith commented Dec 8, 2022

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased unpool-test onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout unpool-test && git pull --rebase)

@soumith
Copy link
Member

soumith commented Dec 8, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@ppwwyyxx @kulinseth
skip flaky tests (rather than expectedFailure) (pytorch#90233)
924cd1c 
They are flaky but don't always fail. So `expectedFailure` is incorrect.
Pull Request resolved: pytorch#90233
Approved by: https://github.com/mruberry, https://github.com/soumith
@ppwwyyxx ppwwyyxx mentioned this pull request Dec 10, 2022
Closed
pytorchmergebot pushed a commit that referenced this pull request Dec 11, 2022
@ppwwyyxx @pytorchmergebot
Skip some unittests (#90609)
8127724 
* Skip a unittest that needs FFT if not built with FFT
* Mark a test with "slow": `python test/test_ops.py -k TestCompositeComplianceCUDA.test_forward_ad_svd_lowrank_cuda_float32` took >5min on my machine.
* Skip a flaky test that's marked "expectedFailure", similar to #90233
Pull Request resolved: #90609
Approved by: https://github.com/soumith
@ppwwyyxx ppwwyyxx deleted the unpool-test branch September 26, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soumith soumith soumith approved these changes

@mruberry mruberry mruberry approved these changes

@ngimel ngimel Awaiting requested review from ngimel

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: python_frontend python frontend release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ppwwyyxx @mruberry @pytorchmergebot @soumith @pytorchbot