-
Notifications
You must be signed in to change notification settings - Fork 25.7k
Track torch.compile calls #90310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track torch.compile calls #90310
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/90310
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 84f1131: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
| """ | ||
| from . import _C | ||
| _C._log_api_usage_once("torch.compile") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from _C import * is already done in this file above (and it's done carefully wrt loader flags).
So, you should just do _C._log_api_usage_once("torch.compile") -> _log_api_usage_once("torch.compile")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the _C in front of _log_api_usage_once is still needed, but _C is already imported, so I can remove the import statement.
|
@pytorchbot merge |
Merge failedReason: Approval needed from one of the following (Rule 'superuser'): Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge |
Merge failedReason: Approval needed from one of the following (Rule 'superuser'): Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Title. Pull Request resolved: pytorch#90310 Approved by: https://github.com/colin2328, https://github.com/anijain2305
Title.