Skip to content

Conversation

mlazos
Copy link
Contributor

@mlazos mlazos commented Dec 6, 2022

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 6, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/90329

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5d4f689:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@mlazos mlazos requested a review from jansel December 7, 2022 01:53
@anijain2305
Copy link
Contributor

Is is_tracing the right word? We are not really tracing, but rather analyzing the bytecode.

@mlazos
Copy link
Contributor Author

mlazos commented Dec 7, 2022

Is is_tracing the right word? We are not really tracing, but rather analyzing the bytecode.

I'm okay with other names, I thought is_tracing was clearest though. What do you suggest?

@soumith
Copy link
Member

soumith commented Dec 8, 2022

maybe is_compiling?

@mlazos
Copy link
Contributor Author

mlazos commented Dec 8, 2022

maybe is_compiling?

Sure, sgtm

@mlazos mlazos changed the title [dynamo] Add is_tracing for dynamo [dynamo] Add is_compiling for dynamo Dec 8, 2022
@mlazos
Copy link
Contributor Author

mlazos commented Dec 9, 2022

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 9, 2022
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the mlazos/is-tracing branch June 9, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants