[threaded pg] make exception handling consistent with MultiProcessTestCase #90712
Conversation
…tCase [ghstack-poisoned]
XilunWu
requested review from
H-Huang,
awgu,
kwen2501,
mrshenli,
pritamdamania87,
rohan-varma,
wanchaol and
zhaojuanmao
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/90712
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 FailuresAs of commit a8aaeab: NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…iProcessTestCase" [ghstack-poisoned]
…iProcessTestCase" [ghstack-poisoned]
…iProcessTestCase" [ghstack-poisoned]
…iProcessTestCase" [ghstack-poisoned]
|
@XilunWu has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
…iProcessTestCase" Differential Revision: [D42153661](https://our.internmc.facebook.com/intern/diff/D42153661) [ghstack-poisoned]
…iProcessTestCase" Differential Revision: [D42153661](https://our.internmc.facebook.com/intern/diff/D42153661) [ghstack-poisoned]
| def wrapper(self, *args, **kwargs): | ||
| _run_test_with_mt_pg( | ||
| self, timeout, world_size, lambda: func(self, *args, **kwargs) | ||
| # TODO: get test name from kwargs |
There was a problem hiding this comment.
what does this todo mean exactly?
There was a problem hiding this comment.
for MultiThreadedTestCase._run_test_with_mt_pg call the first argument should be the test name which can be obtained from self._current_test_name. However, this field is not accessible from this wrapper so I leave this as a TODO.
…iProcessTestCase" Differential Revision: [D42153661](https://our.internmc.facebook.com/intern/diff/D42153661) [ghstack-poisoned]
|
@XilunWu has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@pytorchmergebot merge -g |
Merge startedYour change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 2 additional jobs have failed, first few of them are: trunk ,trunk / linux-focal-rocm5.3-py3.8 / test (default, 2, 2, linux.rocm.gpu) Details for Dev Infra teamRaised by workflow job |
|
This pull request has been merged in a6dcebf. |
4 participants
Stack from ghstack (oldest at bottom):
Differential Revision: D42153661