Skip to content

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Dec 14, 2022

Triton needs a working gcc, so install one from apt
Also, copy ptxas and cuda.h from conda to /usr/local/cuda
Add torchaudio to the matrix
Fix typo in workflow file

Fixes #90377

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 14, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/90841

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b06e58c:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Dec 14, 2022
@malfet malfet requested review from a team and ngimel December 14, 2022 14:32
Dockerfile Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we instead set triton's env var to point to conda's PTXAS, and similarly set envvar to add conda's include to common includes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me try to see if it will work...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, ok, exporting CUDA_HOME=/opt/conda/ works, though it feels a bit weird, is it does not contain nvcc and other tools...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For triton the var is TRITON_PTXAS_PATH

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah but /usr/local/cuda/bin that contains only ptxas is no less weird :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TRITION_PTXAS_PATH only works for PTXAS, but cuda.h is only search in CUDA_HOME folder

Copy link
Contributor Author

@malfet malfet Dec 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, come to think of it:

  • Short term solution should be to create /usr/local/trition-min-cuda-X.Y and symlink to /usr/local/cuda/ (so that if user attempts to install cuda toolkit it will simply override the symlink)
  • Mid-term solution is to package those dependencies into triton and make it search there if its not available in other places

Triton needs a working gcc, so install one from apt
Also, copy ptxas and cuda.h from conda to /usr/local/cuda

Fixes #90377
@malfet malfet force-pushed the malfet/install-more-trition-deps branch from d8cd8ae to b96d2db Compare December 14, 2022 23:00
@malfet
Copy link
Contributor Author

malfet commented Dec 16, 2022

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 16, 2022
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@malfet malfet deleted the malfet/install-more-trition-deps branch June 7, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pytorch 2 error on provided docker but not on pip installation

3 participants