-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[Docker] Install Trition deps #90841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/90841
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b06e58c: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Dockerfile
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we instead set triton's env var to point to conda's PTXAS, and similarly set envvar to add conda's include to common includes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me try to see if it will work...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, ok, exporting CUDA_HOME=/opt/conda/
works, though it feels a bit weird, is it does not contain nvcc and other tools...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For triton the var is TRITON_PTXAS_PATH
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah but /usr/local/cuda/bin
that contains only ptxas
is no less weird :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TRITION_PTXAS_PATH
only works for PTXAS, but cuda.h
is only search in CUDA_HOME
folder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, come to think of it:
- Short term solution should be to create
/usr/local/trition-min-cuda-X.Y
and symlink to/usr/local/cuda/
(so that if user attempts to install cuda toolkit it will simply override the symlink) - Mid-term solution is to package those dependencies into triton and make it search there if its not available in other places
Triton needs a working gcc, so install one from apt Also, copy ptxas and cuda.h from conda to /usr/local/cuda Fixes #90377
d8cd8ae
to
b96d2db
Compare
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Triton needs a working gcc, so install one from apt
Also, copy
ptxas
andcuda.h
from conda to/usr/local/cuda
Add
torchaudio
to the matrixFix typo in workflow file
Fixes #90377