Skip to content

functorch: non-contig samples for test_grad #90990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

functorch: non-contig samples for test_grad #90990

wants to merge 4 commits into from

Conversation

@kshitij12345
Copy link
Collaborator

@kshitij12345 kshitij12345 commented Dec 16, 2022 •
edited
Loading

Ref: pytorch/functorch#1029

Before PR: (Time: ~30s)

================================================= 1052 passed, 264 skipped, 17373 deselected, 9 xfailed in 29.09s =================================================

After PR: (Time: ~43s)

================================================ 1042 passed, 264 skipped, 17373 deselected, 19 xfailed in 43.13s =================================================

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 16, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/90990

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit e86105c:

FLAKY - The following jobs failed but were likely due to flakiness present on master:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Dec 16, 2022
@kshitij12345 kshitij12345 marked this pull request as ready for review December 16, 2022 09:45
@kshitij12345 kshitij12345 changed the title functorch: non-contig samples vmap functorch: non-contig samples for test_grad Dec 16, 2022
kshitij12345
kshitij12345 commented Dec 16, 2022
View reviewed changes
test/functorch/test_ops.py
xfail('as_strided', 'partial_views'),
# RuntimeError: !self.requires_grad() || self.is_contiguous()
xfail('as_strided_scatter'),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ref: #90992

@kshitij12345
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 16, 2022
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 2 additional jobs have failed, first few of them are: trunk ,trunk / linux-focal-rocm5.3-py3.8 / test (default, 1, 2, linux.rocm.gpu)

Details for Dev Infra team Raised by workflow job

@kshitij12345
Copy link
Collaborator Author

@pytorchbot merge -f"ROCM timeout is unrelated"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zou3519 zou3519 zou3519 approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kshitij12345 @pytorchmergebot @zou3519 @pytorchbot