[Inductor] Replace graph.eliminate_dead_code() with graph.erase_node() in Permute Fusion #91014
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91014
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 FailuresAs of commit cef9a48: FLAKY - The following jobs failed but were likely due to flakiness present on master:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D41904755 |
…) in Permute Fusion (pytorch#91014) Summary: Pull Request resolved: pytorch#91014 As FX passes of permute fusion run before functionalization, it might be safer to replace `graph.eliminate_dead_code()` with `graph.erase_node()` to avoid cases that `graph.eliminate_dead_code()` might remove mutation nodes Test Plan: Unit Tests & CI Reviewed By: jansel Differential Revision: D41904755 fbshipit-source-id: 7d14eaac7df2a24b0d0e55e7bd2f547232100423
jiawenliu64
force-pushed
the
export-D41904755
branch
from
f25ca80 to
c2542cb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D41904755 |
jiawenliu64
force-pushed
the
export-D41904755
branch
from
c2542cb to
7120625
Compare
|
This pull request was exported from Phabricator. Differential Revision: D41904755 |
…) in Permute Fusion (pytorch#91014) Summary: Pull Request resolved: pytorch#91014 As FX passes of permute fusion run before functionalization, it might be safer to replace `graph.eliminate_dead_code()` with `graph.erase_node()` to avoid cases that `graph.eliminate_dead_code()` might remove mutation nodes Test Plan: Unit Tests & CI Reviewed By: jansel Differential Revision: D41904755 fbshipit-source-id: 426f4cce5278aa7bc45743078937765258a637b2
jiawenliu64
force-pushed
the
export-D41904755
branch
from
7120625 to
cef9a48
Compare
|
This pull request was exported from Phabricator. Differential Revision: D41904755 |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 2 additional jobs have failed, first few of them are: trunk ,trunk / macos-12-py3-arm64 / test (default, 1, 2, macos-m1-12) Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge -f "Test failure unrelated" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
4 participants
Summary: As FX passes of permute fusion run before functionalization, it might be safer to replace
graph.eliminate_dead_code()withgraph.erase_node()to avoid cases thatgraph.eliminate_dead_code()might remove mutation nodesTest Plan: Unit Tests & CI
Reviewed By: jansel
Differential Revision: D41904755
cc @mlazos @soumith @voznesenskym @yanboliang @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @chunyuan-w @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @desertfire