-
Couldn't load subscription status.
- Fork 25.7k
[vulkan] Remove dependencies from op/ in vTensor and move it to higher level namespace #91023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…r level namespace Small refactor to remove any code used by vTensor under the `op/` folder to appropriate locations in the `api/` folder. Also remove vTensor from the `ops` namespace, it now resides in the higher level `at::native::vulkan` namespace which will also be used for the Graph data structures in the future. This is the last step required for vTensor to be able to moved to the api folder. Differential Revision: [D42052680](https://our.internmc.facebook.com/intern/diff/D42052680/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91023
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 52f1171: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…it to higher level namespace" Small refactor to remove any code used by vTensor under the `op/` folder to appropriate locations in the `api/` folder. Also remove vTensor from the `ops` namespace, it now resides in the higher level `at::native::vulkan` namespace which will also be used for the Graph data structures in the future. This is the last step required for vTensor to be able to moved to the api folder. Differential Revision: [D42052680](https://our.internmc.facebook.com/intern/diff/D42052680/) [ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
|
The merge job was canceled. If you believe this is a mistake,then you can re trigger it through pytorch-bot. |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Stack from ghstack (oldest at bottom):
ops/folder toapi/folder #91033Small refactor to remove any code used by vTensor under the
op/folder to appropriate locations in theapi/folder. Also remove vTensor from theopsnamespace, it now resides in the higher levelat::native::vulkannamespace which will also be used for the Graph data structures in the future.This is the last step required for vTensor to be able to moved to the api folder.
Differential Revision: D42052680