[Inductor] Move graph.lint() in Intel's FX Passes to the End of Loop to Reduce Compile Time #91179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91179
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d1f6447: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D41964322 |
XiaobingSuper
approved these changes
Dec 22, 2022
|
@pytorchbot merge |
Merge failedReason: Approval needed from one of the following (Rule 'superuser'): Details for Dev Infra teamRaised by workflow job |
jansel
approved these changes
Jan 2, 2023
…to Reduce Compile Time Summary: Move `graph.lint()` in Intel's FX passes to the end of loop to reduce compile time, as there is no need to place `graph.lint()` within loop Test Plan: CI Reviewed By: jansel Differential Revision: D41964322 fbshipit-source-id: 69516f4a347e530cd7d09e4a399d540d3043f705
|
This pull request was exported from Phabricator. Differential Revision: D41964322 |
jiawenliu64
force-pushed
the
export-D41964322
branch
from
9229633 to
d1f6447
Compare
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
XiaobingSuper
added a commit
that referenced
this pull request
Jan 4, 2023
…d of Loop to Reduce Compile Time(part 2)" As #91179 to Reduce Compile Time. cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen chunyuan-w zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]
XiaobingSuper
added a commit
that referenced
this pull request
Jan 4, 2023
…Passes to the End of Loop to Reduce Compile Time(part 2)" As #91179 to Reduce Compile Time. cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen chunyuan-w zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]
XiaobingSuper
added a commit
that referenced
this pull request
Jan 4, 2023
…d of Loop to Reduce Compile Time(part 2)" As #91179 to Reduce Compile Time. cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen chunyuan-w zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]
XiaobingSuper
added a commit
that referenced
this pull request
Jan 4, 2023
…Passes to the End of Loop to Reduce Compile Time(part 2)" As #91179 to Reduce Compile Time. cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen chunyuan-w zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]
XiaobingSuper
added a commit
that referenced
this pull request
Jan 4, 2023
…d of Loop to Reduce Compile Time(part 2)" As #91179 to Reduce Compile Time. cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen chunyuan-w zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]
XiaobingSuper
added a commit
that referenced
this pull request
Jan 4, 2023
…Passes to the End of Loop to Reduce Compile Time(part 2)" As #91179 to Reduce Compile Time. cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen chunyuan-w zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]
XiaobingSuper
added a commit
that referenced
this pull request
Jan 4, 2023
…d of Loop to Reduce Compile Time(part 2)" As #91179 to Reduce Compile Time. cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen chunyuan-w zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]
XiaobingSuper
added a commit
that referenced
this pull request
Jan 4, 2023
…Passes to the End of Loop to Reduce Compile Time(part 2)" As #91179 to Reduce Compile Time. cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen chunyuan-w zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]
XiaobingSuper
added a commit
that referenced
this pull request
Jan 4, 2023
…d of Loop to Reduce Compile Time(part 2)" As #91179 to Reduce Compile Time. cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen chunyuan-w zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]
XiaobingSuper
added a commit
that referenced
this pull request
Jan 5, 2023
…Passes to the End of Loop to Reduce Compile Time(part 2)" As #91179 to Reduce Compile Time. cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen chunyuan-w zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]
XiaobingSuper
added a commit
that referenced
this pull request
Jan 5, 2023
…d of Loop to Reduce Compile Time(part 2)" As #91179 to Reduce Compile Time. cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen chunyuan-w zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]
XiaobingSuper
added a commit
that referenced
this pull request
Jan 5, 2023
…Passes to the End of Loop to Reduce Compile Time(part 2)" As #91179 to Reduce Compile Time. cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen chunyuan-w zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]
XiaobingSuper
added a commit
that referenced
this pull request
Jan 5, 2023
…d of Loop to Reduce Compile Time(part 2)" As #91179 to Reduce Compile Time. cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen chunyuan-w zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]
pytorchmergebot
pushed a commit
that referenced
this pull request
Jan 6, 2023
…o Reduce Compile Time(part 2) (#91677) As #91179 to Reduce Compile Time. Pull Request resolved: #91677 Approved by: https://github.com/jgong5, https://github.com/desertfire
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Move
graph.lint()in Intel's FX passes to the end of loop to reduce compile time, as there is no need to placegraph.lint()within loopTest Plan: CI
Reviewed By: jansel
Differential Revision: D41964322
cc @mlazos @soumith @voznesenskym @yanboliang @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @chunyuan-w @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @desertfire