[Resubmit] Require inductor to match stride order #91185
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91185
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 FailuresAs of commit 63b1757: NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
eellison
added
topic: not user facing
| "cov": {f16, f32, f64, i32, i64}, | ||
| "equal": {b8, f16, f32, f64, i32, i64}, | ||
| "fft.fft": {f16, f32, f64}, | ||
| "fft.fft": {b8, f16, f32, f64, i32, i64}, |
There was a problem hiding this comment.
What's the story about these new expected failures?
There was a problem hiding this comment.
fft support here is extremely flakey. they do not work except as a stand alone op. these kernels output complex, so the requiring_stride_order on the end breaks when we interact with complex dtypes
Resubmitting #90563 because I had a commit in that stack which didn't use my CLA-approved git username. cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen chunyuan-w XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]
| # long term the solution is to make view() always succeed | ||
| # with infallible strides. |
There was a problem hiding this comment.
Just for understanding (the PR is ok) - What is view with infallible strides?
There was a problem hiding this comment.
Resubmitting #90563 because I had a commit in that stack which didn't use my CLA-approved git username. cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen chunyuan-w XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]
|
@pytorchbot rebase |
|
@pytorchbot successfully started a rebase job. Check the current status here |
Resubmitting #90563 because I had a commit in that stack which didn't use my CLA-approved git username. cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen chunyuan-w XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]
|
Successfully rebased |
Resubmitting #90563 because I had a commit in that stack which didn't use my CLA-approved git username. cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen chunyuan-w XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]
|
@pytorchbot merge -f "eager variation failures" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
4 participants
Stack from ghstack (oldest at bottom):
Resubmitting #90563 because I had a commit in that stack which didn't use my CLA-approved git username.
cc @mlazos @soumith @voznesenskym @yanboliang @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @chunyuan-w @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @desertfire