Skip to content

Conversation

@jiawenliu64
Copy link
Member

@jiawenliu64 jiawenliu64 commented Dec 22, 2022

Summary: Fix "RuntimeError: Tried to erase Node permute but it still had 3 users in the graph" to unblock internal models

Differential Revision: D42213859

cc @mlazos @soumith @voznesenskym @yanboliang @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @chunyuan-w @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @desertfire

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 22, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91327

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 Failures

As of commit 0ac5a31:

FLAKY - The following jobs failed but were likely due to flakiness present on master:

BROKEN TRUNK - The following jobs failed but were present on the merge base ca39c5b:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D42213859

@ngimel
Copy link
Collaborator

ngimel commented Dec 22, 2022

Can you please add a testcase based on @anijain2305 minifier? You can patch _inductor.config in the test to enable permute fusion.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D42213859

@jiawenliu64
Copy link
Member Author

Synced with @anijain2305: the issue is addressed with tests in minifier, and add tests based on minifier

jiawenliu64 added a commit to jiawenliu64/pytorch that referenced this pull request Dec 23, 2022
…l had 3 users in the graph" (pytorch#91327)

Summary:
Pull Request resolved: pytorch#91327

Fix "RuntimeError: Tried to erase Node permute but it still had 3 users in the graph" to unblock internal models

Reviewed By: anijain2305, ngimel

Differential Revision: D42213859

fbshipit-source-id: ceba64b40a91c37c84e693d640a9e210a9db2365
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D42213859

Copy link
Member

@jianyuh jianyuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase to check the OSS test failure?

@jiawenliu64
Copy link
Member Author

It seems all test failures are due to the sev (#91332). Will check when the sev is solved

…l had 3 users in the graph" (pytorch#91327)

Summary:
Pull Request resolved: pytorch#91327

Fix "RuntimeError: Tried to erase Node permute but it still had 3 users in the graph" to unblock internal models

Reviewed By: anijain2305, jianyuh, ngimel

Differential Revision: D42213859

fbshipit-source-id: ae02b2c75cf67e275fb5dd841a238847904a53d9
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D42213859

@jiawenliu64
Copy link
Member Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 28, 2022
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: The following mandatory check(s) failed (Rule superuser):

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

@jiawenliu64
Copy link
Member Author

@pytorchbot merge -f "failure unrelated"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants