Fix/device type prefixed with c10 namespace in headers

[bsergean]

Fixes #91338

cc @mcarilli @ptrblck @leslie-fang-intel @jgong5

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91342

• 📄 Preview Python docs built from this PR
• 📄 Preview C++ docs built from this PR
• ❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 30 Failures

As of commit 7431216:

NEW FAILURES - The following jobs have failed:

• lintrunner
• linux-bionic-cuda11.6-py3.10-gcc7 / test (default, 1, 4, linux.4xlarge.nvidia.gpu)
• linux-bionic-cuda11.6-py3.10-gcc7 / test (default, 2, 4, linux.4xlarge.nvidia.gpu)
• linux-bionic-cuda11.6-py3.10-gcc7 / test (default, 3, 4, linux.4xlarge.nvidia.gpu)
• linux-bionic-cuda11.6-py3.10-gcc7 / test (default, 4, 4, linux.4xlarge.nvidia.gpu)
• linux-bionic-cuda11.6-py3.10-gcc7 / test (distributed, 1, 3, linux.8xlarge.nvidia.gpu)
• linux-bionic-cuda11.6-py3.10-gcc7 / test (distributed, 2, 3, linux.8xlarge.nvidia.gpu)
• linux-bionic-cuda11.6-py3.10-gcc7 / test (distributed, 3, 3, linux.8xlarge.nvidia.gpu)
• linux-bionic-cuda11.6-py3.10-gcc7 / test (functorch, 1, 1, linux.4xlarge.nvidia.gpu)
• linux-bionic-cuda11.6-py3.10-gcc7-bazel-test / build-and-test
• linux-bionic-py3.7-clang9 / test (crossref, 1, 2, linux.2xlarge)
• linux-bionic-py3.7-clang9 / test (crossref, 2, 2, linux.2xlarge)
• linux-bionic-py3.7-clang9 / test (default, 1, 2, linux.2xlarge)
• linux-bionic-py3.7-clang9 / test (default, 2, 2, linux.2xlarge)
• linux-bionic-py3.7-clang9 / test (dynamo, 1, 2, linux.2xlarge)
• linux-bionic-py3.7-clang9 / test (dynamo, 2, 2, linux.2xlarge)
• linux-bionic-py3.7-clang9 / test (functorch, 1, 1, linux.2xlarge)
• linux-focal-py3.7-clang7-asan / test (default, 1, 5, linux.2xlarge)
• linux-focal-py3.7-clang7-asan / test (default, 2, 5, linux.2xlarge)
• linux-focal-py3.7-clang7-asan / test (default, 3, 5, linux.2xlarge)
• linux-focal-py3.7-clang7-asan / test (default, 4, 5, linux.4xlarge)
• linux-focal-py3.7-clang7-asan / test (default, 5, 5, linux.4xlarge)
• linux-focal-py3.7-clang7-asan / test (functorch, 1, 1, linux.2xlarge)
• linux-focal-py3.7-gcc7 / test (default, 1, 2, linux.2xlarge)
• linux-focal-py3.7-gcc7 / test (default, 2, 2, linux.2xlarge)
• linux-focal-py3.7-gcc7 / test (distributed, 1, 2, linux.2xlarge)
• linux-focal-py3.7-gcc7 / test (distributed, 2, 2, linux.2xlarge)
• linux-focal-py3.7-gcc7 / test (functorch, 1, 1, linux.2xlarge)
• linux-focal-py3.7-gcc7 / test (jit_legacy, 1, 1, linux.2xlarge)
• Test tools

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[linux-foundation-easycla]

• ❌ - login: @bsergean . The commit (7b764e9, bea29b2, 7431216) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

[bdhirsh]

Looks ok to me! Can you sign the CLA?

[bsergean]

Thanks Brian ! I’ll sign the CLA soon, I’m on break right now.

…

On Dec 27, 2022, at 3:15 PM, Brian Hirsh ***@***.***> wrote: Looks ok to me! Can you sign the CLA? — Reply to this email directly, view it on GitHub <#91342 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC2O6UJPF2WWCLE77CTG2M3WPN2AJANCNFSM6AAAAAATHH6NTY>. You are receiving this because you were mentioned.

[albanD]

Sounds good.
Could you also add a lint entry for this to make sure we don't add new ones.
It can be similar to the one below I think:

pytorch/.lintrunner.toml

Lines 766 to 785 in dfb6514

	[[linter]]
	code = 'ONCE_FLAG'
	include_patterns = [
	'c10/**',
	'aten/**',
	'torch/csrc/**',
	]
	command = [
	'python3',
	'tools/linter/adapters/grep_linter.py',
	'--pattern=std::once_flag',
	'--linter-name=ONCE_FLAG',
	'--error-name=invalid once_flag',
	'--replace-pattern=s/std::once_flag/c10::once_flag/',
	"""--error-description=\
	Use of std::once_flag is forbidden and should be replaced with c10::once_flag\
	""",
	'--',
	'@{{PATHSFILE}}'
	]

[github-actions]

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

[bsergean]

Hi there, would it be OK to bring this in without the linter as a start ? And make adding the linter rule a follow-up ?

I can make a new PR with the latest state of the master branch.