Skip to content

[Profiler] Fix SOFT_ASSERT test to not raise on debug builds #91464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Profiler] Fix SOFT_ASSERT test to not raise on debug builds #91464

wants to merge 1 commit into from

Conversation

@aaronenyeshi
Copy link
Member

Summary: There was a patch to not raise SOFT_ASSERT in debug builds. Update this test to match it.

Test Plan: This test passes after this patch.

Differential Revision: D42270123

Pulled By: aaronenyeshi

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 28, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91464

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 3b43261:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Dec 28, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D42270123

robieta
robieta approved these changes Dec 29, 2022
View reviewed changes
Copy link

@robieta robieta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@aaronenyeshi
Copy link
Member Author

@pytorchmergebot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@aaronenyeshi @pytorchmergebot
[Profiler] Fix SOFT_ASSERT test to not raise on debug builds
3b43261 
Summary: There was a patch to not raise SOFT_ASSERT in debug builds. Update this test to match it.

Test Plan: This test passes after this patch.

Differential Revision: D42270123

Pulled By: aaronenyeshi

fbshipit-source-id: b55c9c01adefe9089477145b65910cdbd813ec65
@pytorchmergebot
Copy link
Collaborator

Successfully rebased export-D42270123 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout export-D42270123 && git pull --rebase)

@facebook-github-bot
Copy link
Contributor

@aaronenyeshi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@aaronenyeshi
Copy link
Member Author

@pytorchmergebot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 29, 2022
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@robieta robieta robieta approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aaronenyeshi @facebook-github-bot @pytorchmergebot @robieta