Add a sample for index_fill to test framework #91534
Conversation
pytorch-bot
bot
added
the
release notes: python_frontend
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91534
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit c5a2882: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot label "ciflow: trunk" |
|
Didn't find following labels among repository labels: ciflow: trunk |
|
@pytorchbot label "ciflow/trunk" |
|
Can't add following labels to PR: ciflow/trunk Please ping one of the reviewers for help. |
There was a problem hiding this comment.
I think this is tripping up the tests.
>>> import itertools
>>> list(itertools.product((), (1, 2)))
[]There was a problem hiding this comment.
Thank you for pointing this out! Fixed.
There was a problem hiding this comment.
I think with this you won't need the new xfails.
qqaatw
force-pushed
the
add_index_fill_scalar_value_test
branch
from
911211e to
2355c47
Compare
|
Hi, @kshitij12345 can you help add |
|
Can you try using the label command for pytorchbot. I think that should work otherwise I will add it manually. Thanks! Ref: https://github.com/pytorch/pytorch/wiki/Bot-commands#labeling |
@kshitij12345 As you can see the reply from PyTorch Bot above, it seems that I don't have permissions to add this label using the bot command. Edited: Ok, now it works, not sure why... Thanks. |
|
@pytorchbot label "ciflow/trunk" |
|
@peterbell10 Resolved, all tests are passing now. Thanks. |
qqaatw
requested review from
peterbell10
and removed request for
Chillee,
ezyang,
mruberry,
ngimel,
peterbell10 and
zou3519
|
@ngimel Can you please take a look at the change? thank you. |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: This PR is too stale; the last push date was more than 3 days ago. Please rebase and try again. You can rebase by leaving the following comment on this PR: Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Currently the index_fill test doesn't include a sample with tensor `value` input. This PR adds one. Pull Request resolved: pytorch/pytorch#91534 Approved by: https://github.com/ngimel
Currently the index_fill test doesn't include a sample with tensor `value` input. This PR adds one. Pull Request resolved: pytorch/pytorch#91534 Approved by: https://github.com/ngimel
Currently the index_fill test doesn't include a sample with tensor `value` input. This PR adds one. Pull Request resolved: pytorch#91534 Approved by: https://github.com/ngimel
7 participants
Currently the index_fill test doesn't include a sample with tensor
valueinput.This PR adds one.
cc @mlazos @soumith @voznesenskym @yanboliang @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @chunyuan-w @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @desertfire