Skip to content

Consider updating pin to CMake version 3.23.1 on run_torchbench CI #91739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Consider updating pin to CMake version 3.23.1 on run_torchbench CI #91739

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
90fe0c8
latest version of cmake now safe to use, making pin unnecessary
Jan 4, 2023
b7392ee
pinning cmake version 3.23.1 instead of unpinning to follow dependenc…
Jan 5, 2023
9024480
Relax pin to cmake from 3.22 to 3.22.*
matthewgraca Jan 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/workflows/run_torchbench.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,8 @@ jobs:
# shellcheck source=/dev/null
. "${SETUP_SCRIPT}"
conda activate pr-ci
# pin cmake version to 3.22 since 3.23 breaks pytorch build
# see details at: https://github.com/pytorch/pytorch/issues/74985
conda install -y numpy="${NUMPY_VERSION}" requests ninja pyyaml mkl mkl-include \
setuptools cmake=3.22 cffi typing_extensions boto3 \
setuptools cmake=3.22.* cffi typing_extensions boto3 \
future six dataclasses pillow pytest tabulate gitpython git-lfs tqdm psutil
pip install --pre torch torchvision torchtext -f https://download.pytorch.org/whl/nightly/cu116/torch_nightly.html
- name: Setup TorchBench branch
Expand Down