Skip to content

Conversation

@SherlockNoMad
Copy link
Contributor

@SherlockNoMad SherlockNoMad commented Jan 9, 2023

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 9, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91899

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 4f625b1:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ugh, why doesn't export just take dynamic directly lol

@SherlockNoMad
Copy link
Contributor Author

ugh, why doesn't export just take dynamic directly lol

We should, and this will be an API change for dynamo.export()... and maybe we should do this sooner than latter.

Also, is fake tracing mode still a thing after the Symbolic shape branch is merged. IIUC, we should end up with only two mode, static(real tracing mode) vs. dynamic (symbolic tracing mode) , right?

cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen chunyuan-w XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire

[ghstack-poisoned]
SherlockNoMad added a commit that referenced this pull request Jan 9, 2023
ghstack-source-id: 82c2f33
Pull Request resolved: #91899
@SherlockNoMad
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 9, 2023
@ezyang
Copy link
Contributor

ezyang commented Jan 9, 2023

I would like to get rid of real tracing mode (where you actually run the tensor compute) entirely, but IIRC last time I tried to get rid of it there were... problems

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@SherlockNoMad
Copy link
Contributor Author

I would like to get rid of real tracing mode (where you actually run the tensor compute) entirely, but IIRC last time I tried to get rid of it there were... problems

I think there are still merits of real tracing mode.
In the case of custom op without meta implementation, (or its meta implementation doesn't support symbolic shape), real tracing mode would still work, I am not sure what would happen if it were traced with symbolic mode?

What should be our policy on custom op being traceable?

@facebook-github-bot facebook-github-bot deleted the gh/SherlockNoMad/90/head branch June 8, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants