-
Notifications
You must be signed in to change notification settings - Fork 25.7k
Remove DL_RUNTIME_BUG #91960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove DL_RUNTIME_BUG #91960
Conversation
This macro was made a no-op in #61903 and so we should clean up the surrounding boiler-plate which used it. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91960
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 FailuresAs of commit 6c2f826: FLAKY - The following jobs failed but were likely due to flakiness present on master:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This macro was made a no-op in pytorch#61903 and so we should clean up the surrounding boiler-plate which used it. ghstack-source-id: f159656 Pull Request resolved: pytorch#91960
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manual dead code elimination, cool.
|
@pytorchbot merge -f "The macro is not used anywhere, it's safe to skip the CI" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: Command Details for Dev Infra teamRaised by workflow job |
This macro was made a no-op in #61903 and so we should clean up the surrounding boiler-plate which used it. [ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: Command Details for Dev Infra teamRaised by workflow job |
|
ok, this is just odd, no idea what's going on here. |
|
Nevermind, this was a landrace with #91086. rebase on top of master and do a |
This macro was made a no-op in #61903 and so we should clean up the surrounding boiler-plate which used it. [ghstack-poisoned]
|
@pytorchbot merge -f "The macro is not used anywhere, it's safe to skip CI" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Stack from ghstack (oldest at bottom):
This macro was made a no-op in #61903 and so we should clean up the surrounding
boiler-plate which used it.
cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10