[pytorch] [compososable] make contract() pickle-able through functools wraps #92120

colin2328 · 2023-01-13T00:46:21Z

Summary:
make contract() pickle-able through functools wraps.
This is to get functions wrapped with contract() to work with torch package

Differential Revision: D42491056

pytorch-bot · 2023-01-13T00:46:24Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/92120

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 1 Pending

As of commit b7ee278:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

linux-foundation-easycla · 2023-01-13T00:46:27Z

The committers listed above are authorized under a signed CLA.

✅ login: colin2328 / name: Colin Taylor (b7ee278)

facebook-github-bot · 2023-01-13T00:47:02Z

This pull request was exported from Phabricator. Differential Revision: D42491056

facebook-github-bot · 2023-01-13T00:54:01Z

This pull request was exported from Phabricator. Differential Revision: D42491056

…s wraps (pytorch#92120) Summary: Pull Request resolved: pytorch#92120 make contract() pickle-able through functools wraps. This is to get functions wrapped with contract() to work with torch package Differential Revision: D42491056 fbshipit-source-id: 1d81e18080a04cbfaa0a0295faa94ff297bba487

facebook-github-bot · 2023-01-13T20:01:40Z

This pull request was exported from Phabricator. Differential Revision: D42491056

fegin

LGTM

colin2328 · 2023-01-13T20:59:38Z

@pytorchmergebot -g

pytorch-bot · 2023-01-13T20:59:40Z

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: unrecognized arguments: -g

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci} ...

Try @pytorchbot --help for more info.

colin2328 · 2023-01-13T21:00:06Z

@pytorchbot --help

pytorch-bot · 2023-01-13T21:00:09Z

PyTorchBot Help

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci} ...

In order to invoke the bot on your PR, include a line that starts with
@pytorchbot anywhere in a comment. That line will form the command; no
multi-line commands are allowed. 

Example:
    Some extra context, blah blah, wow this PR looks awesome

    @pytorchbot merge

optional arguments:
  -h, --help            Show this help message and exit.

command:
  {merge,revert,rebase,label,drci}
    merge               Merge a PR
    revert              Revert a PR
    rebase              Rebase a PR
    label               Add label to a PR
    drci                Update Dr. CI

Merge

usage: @pytorchbot merge [-g | -f MESSAGE | -l] [-r [{viable/strict,master}]]

Merge an accepted PR, subject to the rules in .github/merge_rules.json.
By default, this will wait for all required checks (lint, pull) to succeed before merging.

optional arguments:
  -g, --green           Merge when all status checks running on the PR pass. To add status checks, use labels like `ciflow/trunk`.
  -f MESSAGE, --force MESSAGE
                        Merge without checking anything. This requires a reason for auditting purpose, for example:
                        @pytorchbot merge -f 'Minor update to fix lint. Expecting all PR tests to pass'
  -l, --land-checks     [Deprecated - your PR instead now gets the `ciflow/trunk` label on approval] Merge with land time checks. This will create a new branch with your changes rebased on viable/strict and run a majority of trunk tests _before_ landing to increase trunk reliability and decrease risk of revert. The tests added are: pull, Lint and trunk. Note that periodic is excluded.
  -r [{viable/strict,master}], --rebase [{viable/strict,master}]
                        Rebase the PR to re run checks before merging.  Accepts viable/strict or master as branch options and will default to viable/strict if not specified.

Revert

usage: @pytorchbot revert -m MESSAGE -c
                          {nosignal,ignoredsignal,landrace,weird,ghfirst}

Revert a merged PR. This requires that you are a Meta employee.

Example:
  @pytorchbot revert -m="This is breaking tests on trunk. hud.pytorch.org/" -c=nosignal

optional arguments:
  -m MESSAGE, --message MESSAGE
                        The reason you are reverting, will be put in the commit message. Must be longer than 3 words.
  -c {nosignal,ignoredsignal,landrace,weird,ghfirst}, --classification {nosignal,ignoredsignal,landrace,weird,ghfirst}
                        A machine-friendly classification of the revert reason.

Rebase

usage: @pytorchbot rebase [-s | -b BRANCH]

Rebase a PR. Rebasing defaults to the stable viable/strict branch of pytorch.
You must have write permissions to the repo to rebase a PR.

optional arguments:
  -s, --stable          [DEPRECATED] Rebase onto viable/strict
  -b BRANCH, --branch BRANCH
                        Branch you would like to rebase to

Label

usage: @pytorchbot label labels [labels ...]

Adds label to a PR

positional arguments:
  labels  Labels to add to given Pull Request

Dr CI

usage: @pytorchbot drci

Update Dr. CI. Updates the Dr. CI comment on the PR in case it's gotten out of sync with actual CI results.

colin2328 · 2023-01-13T21:00:31Z

@pytorchbot merge -g

pytorchmergebot · 2023-01-13T21:02:36Z

Merge started

Your change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

awgu

Not sure if this will help the merge rule issue

pytorchmergebot · 2023-01-14T00:19:27Z

Merge failed

Reason: The following mandatory check(s) failed (Rule Distributed):

pull

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

colin2328 · 2023-01-14T05:52:02Z

@pytorchmergebot merge -g

pytorchmergebot · 2023-01-14T05:53:37Z

Merge started

Your change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2023-01-14T05:53:41Z

Merge failed

Reason: The following mandatory check(s) failed (Rule Distributed):

pull

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

colin2328 · 2023-01-17T18:10:13Z

@pytorchmergebot merge -g

pytorchmergebot · 2023-01-17T18:13:59Z

Merge started

Your change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

colin2328 requested review from H-Huang, awgu, kwen2501, mrshenli, rohan-varma, yhcharles and zhaojuanmao as code owners January 13, 2023 00:46

pytorch-bot bot added the release notes: package/deploy release notes category label Jan 13, 2023

facebook-github-bot added the fb-exported label Jan 13, 2023

colin2328 force-pushed the export-D42491056 branch from 430b58e to bfa4953 Compare January 13, 2023 00:54

colin2328 force-pushed the export-D42491056 branch from bfa4953 to b7ee278 Compare January 13, 2023 20:01

fegin approved these changes Jan 13, 2023

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 13, 2023

awgu approved these changes Jan 13, 2023

View reviewed changes

rohan-varma approved these changes Jan 13, 2023

View reviewed changes

mrshenli approved these changes Jan 13, 2023

View reviewed changes

pytorchmergebot added the Merged label Jan 17, 2023

pytorchmergebot closed this in 933cc67 Jan 17, 2023

[pytorch] [compososable] make contract() pickle-able through functools wraps #92120

[pytorch] [compososable] make contract() pickle-able through functools wraps #92120

Uh oh!

Conversation

colin2328 commented Jan 13, 2023

Uh oh!

pytorch-bot bot commented Jan 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/92120

⏳ No Failures, 1 Pending

Uh oh!

linux-foundation-easycla bot commented Jan 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Jan 13, 2023

Uh oh!

facebook-github-bot commented Jan 13, 2023

Uh oh!

facebook-github-bot commented Jan 13, 2023

Uh oh!

fegin left a comment

Choose a reason for hiding this comment

Uh oh!

colin2328 commented Jan 13, 2023

Uh oh!

pytorch-bot bot commented Jan 13, 2023

Uh oh!

colin2328 commented Jan 13, 2023

Uh oh!

pytorch-bot bot commented Jan 13, 2023

PyTorchBot Help

Merge

Revert

Rebase

Label

Dr CI

Uh oh!

colin2328 commented Jan 13, 2023

Uh oh!

pytorchmergebot commented Jan 13, 2023

Merge started

Uh oh!

awgu left a comment

Choose a reason for hiding this comment

Uh oh!

pytorchmergebot commented Jan 14, 2023

Merge failed

Uh oh!

colin2328 commented Jan 14, 2023

Uh oh!

pytorchmergebot commented Jan 14, 2023

Merge started

Uh oh!

pytorchmergebot commented Jan 14, 2023

Merge failed

Uh oh!

colin2328 commented Jan 17, 2023

Uh oh!

pytorchmergebot commented Jan 17, 2023

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

pytorch-bot bot commented Jan 13, 2023 •

edited

Loading

linux-foundation-easycla bot commented Jan 13, 2023 •

edited

Loading