Skip to content

fix the formatting of runtime error msg in prims _cat_meta #92124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix the formatting of runtime error msg in prims _cat_meta #92124

wants to merge 1 commit into from

Conversation

@dshi7
Copy link
Contributor

@dshi7 dshi7 commented Jan 13, 2023

Summary:
easy fix on formatting. for example,

BackendCompilerFailed: compile_fx raised RuntimeError: Sizes of tensors must match except in dimension 0. Expected {common_length} but got {length} for tensor number {tensor_idx} in the list

Reviewed By: Yuzhen11

Differential Revision: D42491648

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 13, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/92124

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 Failures

As of commit 877a6b3:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 13, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: dshi7 / name: daohang (18cb434770062127466985749dcc0d6fffddb733)

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D42491648

@dshi7
Copy link
Contributor Author

dshi7 commented Jan 13, 2023

/easycla

@facebook-github-bot
Copy link
Contributor

@dshi7 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

malfet
malfet approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@malfet malfet added ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category labels Jan 18, 2023
@malfet
Copy link
Contributor

malfet commented Jan 18, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR is too stale; the last push date was more than 3 days ago. Please rebase and try again. You can rebase by leaving the following comment on this PR:
@pytorchbot rebase

Details for Dev Infra team Raised by workflow job

@malfet
Copy link
Contributor

malfet commented Jan 18, 2023

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@dshi7 @pytorchmergebot
fix the formatting of runtime error msg in prims _cat_meta
877a6b3 
Summary:
easy fix on formatting.  for example,
> BackendCompilerFailed: compile_fx raised RuntimeError: Sizes of tensors must match except in dimension 0. Expected {common_length} but got {length} for tensor number {tensor_idx} in the list

Reviewed By: Yuzhen11

Differential Revision: D42491648

fbshipit-source-id: 9209718b4efe5a2450128eb3b32fd95ce03b798e
@pytorchmergebot
Copy link
Collaborator

Successfully rebased export-D42491648 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout export-D42491648 && git pull --rebase)

@malfet
Copy link
Contributor

malfet commented Jan 18, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR has internal changes and must be landed via Phabricator

Details for Dev Infra team Raised by workflow job

@facebook-github-bot
Copy link
Contributor

@dshi7 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@malfet
Copy link
Contributor

malfet commented Jan 18, 2023 •
edited
Loading

Merge failed

Reason: This PR has internal changes and must be landed via Phabricator

Details for Dev Infra team

@bigfootjon I don't think this is a correct signal, as it does not have any non-public changes in the diff

@bigfootjon
Copy link
Member

I think the signal was just a bit slow to update, looks happy now

@malfet
Copy link
Contributor

malfet commented Jan 20, 2023

@pytorchbot merge -f "Win failures are unrelated"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dshi7 @facebook-github-bot @malfet @pytorchmergebot @bigfootjon