Skip to content

Conversation

@ngimel
Copy link
Collaborator

@ngimel ngimel commented Jan 18, 2023

For better perf with MLIR triton.
Changes

tmp32 = tl.load(seed3 + (0 + tl.zeros([XBLOCK, RBLOCK], tl.int32)), None)

to

tmp32_load = tl.load(seed3+(0)); tmp32 = tl.broadcast_to(tmp32_load, [XBLOCK, RBLOCK])

cc @mlazos @soumith @voznesenskym @yanboliang @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @chunyuan-w @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @desertfire @Jokeren

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 18, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/92595

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 Failures, 1 Pending

As of commit eed2a9c:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@ngimel
Copy link
Collaborator Author

ngimel commented Jan 19, 2023

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased ngimel/inductor_load_0 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout ngimel/inductor_load_0 && git pull --rebase)

@ngimel ngimel changed the title let inductor generated when loading a single value let inductor generate broadcast when loading a single value Jan 19, 2023
@ngimel ngimel force-pushed the ngimel/inductor_load_0 branch from 62f89cf to eed2a9c Compare January 19, 2023 17:47
@ngimel
Copy link
Collaborator Author

ngimel commented Jan 20, 2023

@pytorchbot merge -f "test failures unrelated"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the ngimel/inductor_load_0 branch July 21, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants