Skip to content

[ FL-gradient quantization] Adding QNN unpack feature #92714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[ FL-gradient quantization] Adding QNN unpack feature #92714

wants to merge 1 commit into from

Conversation

@kwanghoon-meta
Copy link
Contributor

@kwanghoon-meta kwanghoon-meta commented Jan 20, 2023 •
edited by pytorch-bot bot
Loading

Summary: We are trying to add a new feature for quantized gradient computation which enables backward() function for QNNPACK

Test Plan: buck2 test //caffe2/test/quantization:quantization -- test_qlinear_qnnpack_free_memory_and_unpack

Differential Revision: D40927291

cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 20, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/92714

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d6a8dd2:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 20, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: kwanghoon-meta (982f5b74bcb87060168be45e0177f11b24b6b82d)

@pytorch-bot pytorch-bot bot added the release notes: quantization release notes category label Jan 20, 2023
@github-actions github-actions bot added the module: cpu CPU specific problem (e.g., perf, algorithm) label Jan 20, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40927291

digantdesai
digantdesai approved these changes Jan 21, 2023
View reviewed changes
Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40927291

jianyuh
jianyuh requested changes Jan 21, 2023
View reviewed changes
Copy link
Member

@jianyuh jianyuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check lint / test failures.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40927291

@kwanghoon-meta kwanghoon-meta requested review from jianyuh and removed request for jerryzh168, kimishpatel and salilsdesai January 21, 2023 08:06
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40927291

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40927291

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40927291

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40927291

@facebook-github-bot
Copy link
Contributor

@kwanghoon-meta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@facebook-github-bot
Copy link
Contributor

@kwanghoon-meta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40927291

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40927291

@facebook-github-bot
Copy link
Contributor

@kwanghoon-meta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40927291

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40927291

@kwanghoon-meta @facebook-github-bot
[ FL-gradient quantization] Adding QNN unpack feature (pytorch#92714)
d6a8dd2 
Summary:
We are trying to add a new feature for quantized gradient computation which enables backward() function for QNNPACK

Pull Request resolved: pytorch#92714

Test Plan:
buck2 test //caffe2/test/quantization:quantization -- test_qlinear_qnnpack_free_memory_and_unpack

cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10

Reviewed By: digantdesai, jianyuh

Differential Revision: D40927291

Pulled By: kwanghoon-meta

fbshipit-source-id: 50e7330c1746655261fa00e41a4e4c966c27bb78
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40927291

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 27, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@digantdesai digantdesai digantdesai approved these changes

@jianyuh jianyuh jianyuh approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged module: cpu CPU specific problem (e.g., perf, algorithm) release notes: quantization release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kwanghoon-meta @facebook-github-bot @pytorchmergebot @digantdesai @jianyuh