Skip to content

update README.md to reflect current build from source status on master #92729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

update README.md to reflect current build from source status on master #92729

wants to merge 1 commit into from

Conversation

mikebrow
Copy link
Contributor

@mikebrow mikebrow commented Jan 20, 2023 •
edited
Loading

Signed-off-by: Mike Brown brownwm@us.ibm.com

To avoid new contributor issues when building master a couple README.md comments will help... This change:

- Documents the current support restriction to apt package g++-9 #91328 ** noting here that with the commit in #92911 g++-11.3 appears to build and run local tests at least as well as g++9, so this restriction may be overcome with that PR merge depending on success and CI updates. (fixed now)

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 20, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/92729

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ae8a1ed:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 20, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: mikebrow / name: Mike Brown (ae8a1ed)

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jan 20, 2023
@H-Huang H-Huang requested a review from malfet January 23, 2023 15:17
@H-Huang H-Huang added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jan 23, 2023
@kit1980 kit1980 requested a review from svekars February 11, 2023 00:33
svekars
svekars reviewed Mar 7, 2023
View reviewed changes
@mikebrow mikebrow force-pushed the update-README-gcc-cuda-max-values branch from 4fc79c4 to 18a1ce6 Compare April 5, 2023 21:57
@kit1980
Copy link
Contributor

kit1980 commented Jun 15, 2023

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased update-README-gcc-cuda-max-values onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout update-README-gcc-cuda-max-values && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the update-README-gcc-cuda-max-values branch from 18a1ce6 to ae8a1ed Compare June 15, 2023 19:33
@kit1980
Copy link
Contributor

kit1980 commented Jun 15, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 15, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@mikebrow mikebrow deleted the update-README-gcc-cuda-max-values branch June 19, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@svekars svekars svekars left review comments

@malfet malfet Awaiting requested review from malfet

+1 more reviewer

@kit1980 kit1980 kit1980 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mikebrow @kit1980 @pytorchmergebot @svekars @H-Huang @pytorchbot