[ROCm] Also look for 'Cijk' (rocblas kernel) to verify gemm in test_kineto #92889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorch-bot
bot
added
module: rocm
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/92889
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 7aad487: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
mikaylagawarecki
added
the
triaged
|
@pytorchbot rebase |
|
@pytorchbot successfully started a rebase job. Check the current status here |
|
Successfully rebased |
pytorchmergebot
force-pushed
the
fix_test_kineto
branch
from
58fe1ac to
d01e856
Compare
jithunnair-amd
force-pushed
the
fix_test_kineto
branch
from
d01e856 to
7aad487
Compare
jithunnair-amd
added
the
rocm priority
malfet
approved these changes
Apr 28, 2023
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #88207 enabled ActivityType::CUDA for ROCm. TestProfiler.test_kineto needs an update in the test code to look for the correct pattern for gemm kernels for ROCm.
cc @jeffdaily @sunway513 @pruthvistony @ROCmSupport @mwootton