Skip to content

Enable retry support for MPS tests #94070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Enable retry support for MPS tests #94070

wants to merge 1 commit into from

Conversation

@huydhn
Copy link
Contributor

@huydhn huydhn commented Feb 3, 2023

Here is an example https://hud.pytorch.org/pytorch/pytorch/commit/d7c71a95b68dfd3b126acd021e05b18b5fa38f03 where the MPS test was flaky but not retried. Thus it failed. We probably would want to support retry on MPS tests like the rest of the CI

@huydhn huydhn added ciflow/mps Run MPS tests (subset of trunk) test-config/default labels Feb 3, 2023
@huydhn huydhn requested a review from clee2000 February 3, 2023 21:08
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Feb 3, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 3, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/94070

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit dfc85fb:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@huydhn huydhn marked this pull request as ready for review February 3, 2023 21:16
@huydhn huydhn requested a review from a team as a code owner February 3, 2023 21:16
@huydhn
Copy link
Contributor Author

huydhn commented Feb 3, 2023

@pytorchbot merge -f 'MPS jobs have passed. Skipping trunk to save some trees'

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

ZainRizvi
ZainRizvi reviewed Feb 3, 2023
View reviewed changes
Copy link
Contributor

@ZainRizvi ZainRizvi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I wonder why this wasn't added back when we enabled MPS support

@huydhn
Copy link
Contributor Author

huydhn commented Feb 3, 2023

Nice. I wonder why this wasn't added back when we enabled MPS support

I guess it was a miss. MPS only runs like 2 test files

@huydhn huydhn deleted the add-retry-support-mps branch September 18, 2025 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZainRizvi ZainRizvi ZainRizvi left review comments

@clee2000 clee2000 clee2000 approved these changes

Assignees

No one assigned

Labels

ciflow/mps Run MPS tests (subset of trunk) Merged test-config/default topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@huydhn @pytorchmergebot @ZainRizvi @clee2000