Skip to content

Run test_serialization serially (for 2xlarge runners) #94613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Run test_serialization serially (for 2xlarge runners) #94613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
90e0729
WIP
huydhn Feb 10, 2023
2dc9cb7
Fixes https://github.com/pytorch/pytorch/issues/92746
huydhn Feb 10, 2023
b66b542
Fixes https://github.com/pytorch/pytorch/issues/92746
huydhn Feb 10, 2023
91b3b1b
Fix missing import
huydhn Feb 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions test/run_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,6 +319,7 @@ def skip_test_p(name: str) -> bool:
'functorch/test_vmap', # OOM
'test_fx', # gets SIGKILL
'test_dataloader', # frequently hangs for ROCm
'test_serialization', # test_serialization_2gb_file allocates a tensor of 2GB, and could cause OOM
]

# A subset of our TEST list that validates PyTorch's ops, modules, and autograd function as expected
Expand Down
3 changes: 3 additions & 0 deletions test/test_serialization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import io
import tempfile
import os
import gc
import sys
import zipfile
import warnings
Expand Down Expand Up @@ -905,6 +906,8 @@ def test_serialization_zipfile_actually_jit(self):

# Ensure large zip64 serialization works properly
def test_serialization_2gb_file(self):
# Run GC to clear up as much memory as possible before running this test
gc.collect()
big_model = torch.nn.Conv2d(20000, 3200, kernel_size=3)

with BytesIOContext() as f:
Expand Down