dynamo: wrap graph break inst in try except block - with context manager setup/teardown #94758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etup-with-prefix-after-FailedInlining
…on/dynamo-setup-with-prefix-after-FailedInlining
…on/dynamo-setup-with-prefix-after-FailedInlining
…on/dynamo-setup-with-prefix-after-FailedInlining
jon-chuang
commented
Feb 14, 2023
ngimel
added
the
triaged
yanboliang
reviewed
Mar 1, 2023
|
Gently ping @jon-chuang, can you address these inline comments? We hit another bug #94758, which potentially can be fixed by this. It's good we can merge this ASAP. |
|
Hello @yanboliang , should be ready now. |
|
We need to add a |
yanboliang
approved these changes
Mar 4, 2023
There was a problem hiding this comment.
LGTM, cc @williamwen42 to check if this breaks any Python 3.11 change.
I guess full 3.11 testing is not currently in CI? Else if it is, it seems safe to merge. |
|
@pytorchmergebot merge |
Anw, if it turns out there is a problem, we can fix it, for now I'll assume CI is the source of truth here. |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 12, 2023
…ger setup/teardown (#94758) Replacement to pytorch/pytorch#94672. Follow up to pytorch/pytorch#94137. We simply replace the set grad mode try except blocks with one for a more generic contextmanager (using `__enter__` and `__exit__`), storing the context manager into a `symbolic_local` for the duration of the try block. (see pytorch/torchdynamo#207 for the original motivation) This allows us to handle calling inner functions with graph breaks for any arbitrarily deep nesting of live context managers subclassing `AbstractContextManager`. (see tests) Pull Request resolved: pytorch/pytorch#94758 Approved by: https://github.com/yanboliang
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 12, 2023
…ger setup/teardown (#94758) Replacement to pytorch/pytorch#94672. Follow up to pytorch/pytorch#94137. We simply replace the set grad mode try except blocks with one for a more generic contextmanager (using `__enter__` and `__exit__`), storing the context manager into a `symbolic_local` for the duration of the try block. (see pytorch/torchdynamo#207 for the original motivation) This allows us to handle calling inner functions with graph breaks for any arbitrarily deep nesting of live context managers subclassing `AbstractContextManager`. (see tests) Pull Request resolved: pytorch/pytorch#94758 Approved by: https://github.com/yanboliang
ydwu4
added a commit
to ydwu4/pytorch
that referenced
this pull request
Mar 13, 2023
…ger setup/teardown (pytorch#94758) Replacement to pytorch#94672. Follow up to pytorch#94137. We simply replace the set grad mode try except blocks with one for a more generic contextmanager (using `__enter__` and `__exit__`), storing the context manager into a `symbolic_local` for the duration of the try block. (see pytorch/torchdynamo#207 for the original motivation) This allows us to handle calling inner functions with graph breaks for any arbitrarily deep nesting of live context managers subclassing `AbstractContextManager`. (see tests) Pull Request resolved: pytorch#94758 Approved by: https://github.com/yanboliang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement to #94672.
Follow up to #94137.
We simply replace the set grad mode try except blocks with one for a more generic contextmanager (using
__enter__and__exit__), storing the context manager into asymbolic_localfor the duration of the try block.(see pytorch/torchdynamo#207 for the original motivation)
This allows us to handle calling inner functions with graph breaks for any arbitrarily deep nesting of live context managers subclassing
AbstractContextManager. (see tests)cc @soumith @voznesenskym @yanboliang @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @desertfire @jansel @ngimel @Chillee