Skip to content

SymIntify topk #95015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

SymIntify topk #95015

wants to merge 1 commit into from

Conversation

ymwangg
Copy link
Contributor

@ymwangg ymwangg commented Feb 16, 2023

Companion PR for pytorch/xla#4644.

@pytorch-bot
Copy link

pytorch-bot bot commented Feb 16, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/95015

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit f86279c:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@dagitses dagitses added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Feb 17, 2023
@JackCaoG
Copy link
Collaborator

@ezyang Can someone from the ds side take a look at this pr? Thanks!

@ezyang
Copy link
Contributor

ezyang commented Feb 24, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 24, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR is too stale; the last push date was more than 3 days ago. Please rebase and try again. You can rebase by leaving the following comment on this PR:
@pytorchbot rebase

Details for Dev Infra team Raised by workflow job

@ymwangg
Copy link
Contributor Author

ymwangg commented Feb 24, 2023

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased topk_symint onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout topk_symint && git pull --rebase)

@ymwangg
Copy link
Contributor Author

ymwangg commented Feb 24, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 2 jobs have failed, first few of them are: Check Labels / Check labels, trunk / android-emulator-build-test / build-and-test

Details for Dev Infra team Raised by workflow job

@ymwangg
Copy link
Contributor Author

ymwangg commented Feb 24, 2023

All tests passed except # This PR needs a label. Not sure why this happens.

@ezyang
Copy link
Contributor

ezyang commented Feb 24, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Feb 25, 2023
@ymwangg @cyyever
SymIntify topk (#95015)
fa9ad40 
Companion PR for pytorch/xla#4644.

Pull Request resolved: pytorch/pytorch#95015
Approved by: https://github.com/ezyang
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Feb 25, 2023
@ymwangg @cyyever
SymIntify topk (#95015)
dd0e7fe 
Companion PR for pytorch/xla#4644.

Pull Request resolved: pytorch/pytorch#95015
Approved by: https://github.com/ezyang
@msaroufim msaroufim mentioned this pull request Mar 3, 2023
Closed
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 5, 2023
@ymwangg @cyyever
SymIntify topk (#95015)
0b08472 
Companion PR for pytorch/xla#4644.

Pull Request resolved: pytorch/pytorch#95015
Approved by: https://github.com/ezyang
pruthvistony added a commit to ROCm/pytorch that referenced this pull request May 2, 2023
@pruthvistony
Revert "SymIntify topk (pytorch#95015)"
182f3d2 
This reverts commit b855b5e.
jhavukainen pushed a commit to kulinseth/pytorch that referenced this pull request Mar 15, 2024
@ymwangg @jhavukainen
SymIntify topk (pytorch#95015)
56d5ba4 
Companion PR for pytorch/xla#4644.

Pull Request resolved: pytorch#95015
Approved by: https://github.com/ezyang
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

@albanD albanD Awaiting requested review from albanD

@soulitzer soulitzer Awaiting requested review from soulitzer

Assignees

@albanD albanD

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamic shapes open source release notes: composability release notes category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ymwangg @JackCaoG @ezyang @pytorchmergebot @dagitses @albanD @pytorchbot