Skip to content

feat(dockerfile): shrink layers & build cleaner #95375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat(dockerfile): shrink layers & build cleaner #95375

wants to merge 1 commit into from

Conversation

georgettica
Copy link
Contributor

this change will reduce the layer size as it will not save the layers also it will build cleaner on other machines as it won't ask for a user interaction when running the build

Fixes #ISSUE_NUMBER

@pytorch-bot
Copy link

pytorch-bot bot commented Feb 23, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/95375

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 1 Pending

As of commit 24834cd:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 23, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: georgettica / name: Ron Green (2a01670)

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Feb 23, 2023
ezyang
ezyang requested changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@ezyang
Copy link
Contributor

ezyang commented Feb 27, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 27, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR is too stale; the last push date was more than 3 days ago. Please rebase and try again. You can rebase by leaving the following comment on this PR:
@pytorchbot rebase

Details for Dev Infra team Raised by workflow job

@ezyang
Copy link
Contributor

ezyang commented Feb 28, 2023

@pytorchbot merge -r master

@ezyang ezyang mentioned this pull request Feb 28, 2023
Closed
@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@georgettica @pytorchmergebot
feat(dockerfile): shrink layers & build cleaner
24834cd 
this change will reduce the layer size as it will not save the layers
also it will build cleaner on other machines as it won't ask for a user interaction when running the build
@pytorchmergebot
Copy link
Collaborator

Successfully rebased patch-1 onto refs/remotes/origin/master, please pull locally before adding more changes (for example, via git checkout patch-1 && git pull --rebase)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 2 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@ezyang
Copy link
Contributor

ezyang commented Feb 28, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled. If you believe this is a mistake,then you can re trigger it through pytorch-bot.

@georgettica
Copy link
Contributor Author

doesn't look like this last build is going to pass

@ezyang
Copy link
Contributor

ezyang commented Mar 1, 2023

@pytorchbot merge -f "bypassing stuck filter job"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@georgettica
Copy link
Contributor Author

@ezyang this means this is merged? or not?
I saw the CI failed on a pull error on a file I was not touching

I will keep this branch open for now

@georgettica
Copy link
Contributor Author

seems it was merged :)
1c52666

deleting branch

@georgettica georgettica deleted the patch-1 branch March 1, 2023 12:08
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 2, 2023
@georgettica @cyyever
feat(dockerfile): shrink layers & build cleaner (#95375)
d4920e9 
this change will reduce the layer size as it will not save the layers also it will build cleaner on other machines as it won't ask for a user interaction when running the build

Fixes #ISSUE_NUMBER

Pull Request resolved: pytorch/pytorch#95375
Approved by: https://github.com/ezyang
@msaroufim msaroufim mentioned this pull request Mar 3, 2023
Closed
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 5, 2023
@georgettica @cyyever
feat(dockerfile): shrink layers & build cleaner (#95375)
3068d72 
this change will reduce the layer size as it will not save the layers also it will build cleaner on other machines as it won't ask for a user interaction when running the build

Fixes #ISSUE_NUMBER

Pull Request resolved: pytorch/pytorch#95375
Approved by: https://github.com/ezyang
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 5, 2023
@georgettica @cyyever
feat(dockerfile): shrink layers & build cleaner (#95375)
2c3607d 
this change will reduce the layer size as it will not save the layers also it will build cleaner on other machines as it won't ask for a user interaction when running the build

Fixes #ISSUE_NUMBER

Pull Request resolved: pytorch/pytorch#95375
Approved by: https://github.com/ezyang
pruthvistony added a commit to ROCm/pytorch that referenced this pull request May 2, 2023
@pruthvistony
Revert "feat(dockerfile): shrink layers & build cleaner (pytorch#95375)"
f43b554 
This reverts commit 1c52666.
malfet pushed a commit that referenced this pull request May 12, 2023
@georgettica @malfet
feat(dockerfile): shrink layers & build cleaner (#95375)
96ca226 
this change will reduce the layer size as it will not save the layers also it will build cleaner on other machines as it won't ask for a user interaction when running the build

Fixes #ISSUE_NUMBER

Pull Request resolved: #95375
Approved by: https://github.com/ezyang

(cherry picked from commit 1c52666)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@georgettica @ezyang @pytorchmergebot @pytorchbot