Skip to content

Add bfloat16 support to upsample #95500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 10 commits into from
Closed

Add bfloat16 support to upsample #95500

wants to merge 10 commits into from

Conversation

jamaliki
Copy link
Contributor

Fixes #80339

This PR was previously here: #95159

@pytorch-bot
Copy link

pytorch-bot bot commented Feb 24, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/95500

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 1 Pending

As of commit 50d61fc:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@jamaliki jamaliki mentioned this pull request Feb 24, 2023
Closed
@eqy eqy added topic: not user facing topic category ciflow/trunk Trigger trunk jobs on your pull request labels Feb 24, 2023
@eqy
Copy link
Collaborator

eqy commented Feb 25, 2023

@pytorchmergebot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased add_bfloat16_support_to_upsample onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout add_bfloat16_support_to_upsample && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the add_bfloat16_support_to_upsample branch from be247db to 89958e1 Compare February 25, 2023 06:42
@jamaliki
Copy link
Contributor Author

@eqy I think this is good to go now

@ezyang ezyang requested a review from eqy February 27, 2023 15:47
ezyang
ezyang reviewed Feb 27, 2023
View reviewed changes
torch/testing/_internal/common_methods_invocations.py
yield SampleInput(tensor_1d(), dim=0, unbiased=True, keepdim=True)
yield SampleInput(tensor_1d(), dim=0, unbiased=False, keepdim=False)

yield SampleInput(tensor_nd(), dim=(1,), correction=1.3)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how come?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, this was done by mistake. Put back in now

@ezyang ezyang added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Feb 27, 2023
@ezyang
Copy link
Contributor

ezyang commented Feb 27, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 1, 2023
@jamaliki @cyyever
Add bfloat16 support to upsample (#95500)
a889ae7 
Fixes pytorch/pytorch#80339

This PR was previously here: pytorch/pytorch#95159
Pull Request resolved: pytorch/pytorch#95500
Approved by: https://github.com/ezyang
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 2, 2023
@jamaliki @cyyever
Add bfloat16 support to upsample (#95500)
08ec06f 
Fixes pytorch/pytorch#80339

This PR was previously here: pytorch/pytorch#95159
Pull Request resolved: pytorch/pytorch#95500
Approved by: https://github.com/ezyang
@msaroufim msaroufim mentioned this pull request Mar 3, 2023
Closed
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 5, 2023
@jamaliki @cyyever
Add bfloat16 support to upsample (#95500)
2022e97 
Fixes pytorch/pytorch#80339

This PR was previously here: pytorch/pytorch#95159
Pull Request resolved: pytorch/pytorch#95500
Approved by: https://github.com/ezyang
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 5, 2023
@jamaliki @cyyever
Add bfloat16 support to upsample (#95500)
51c5622 
Fixes pytorch/pytorch#80339

This PR was previously here: pytorch/pytorch#95159
Pull Request resolved: pytorch/pytorch#95500
Approved by: https://github.com/ezyang
@mreyarea-fy
Copy link

I just built the nightly version but this is not available yet. When will it be added?

@jamaliki
Copy link
Contributor Author

jamaliki commented Mar 7, 2023

@mreyarea-fy I just installed '2.1.0.dev20230307+cu117' and it ran just fine

@Cyberbeing
Copy link

It would appear this change did not make it into the final Torch 2.0.0 build released the other day, which is unfortunate.

I was hopeful, with the first nightly it appeared in being torch-2.0.0.dev20230228, but I guess it must have been committed too close to 2.0.0 release cut-off to be included.

Does this mean it now won't appear in a release build until Torch 2.1.0, or is there some other problem which is currently holding it back from being included in a release build?

@jamaliki
Copy link
Contributor Author

Yes I also don't think it made it to Pytorch-2.0. I know it is in Pytorch-2.1

cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 27, 2023
@jamaliki @cyyever
Add bfloat16 support to upsample (#95500)
2061e7d 
Fixes pytorch/pytorch#80339

This PR was previously here: pytorch/pytorch#95159
Pull Request resolved: pytorch/pytorch#95500
Approved by: https://github.com/ezyang
@d4l3k d4l3k mentioned this pull request Apr 6, 2023
Closed
pruthvistony added a commit to ROCm/pytorch that referenced this pull request May 2, 2023
@pruthvistony
Revert "Add bfloat16 support to upsample (pytorch#95500)"
89358ae 
This reverts commit 1cf11c1.
jhavukainen pushed a commit to kulinseth/pytorch that referenced this pull request Mar 15, 2024
@jamaliki @jhavukainen
Add bfloat16 support to upsample (pytorch#95500)
de81cf8 
Fixes pytorch#80339

This PR was previously here: pytorch#95159
Pull Request resolved: pytorch#95500
Approved by: https://github.com/ezyang
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

@mruberry mruberry Awaiting requested review from mruberry

@ngimel ngimel Awaiting requested review from ngimel

@eqy eqy Awaiting requested review from eqy

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BFloat16 support for upsampling on CUDA

7 participants

@jamaliki @eqy @pytorchmergebot @ezyang @mreyarea-fy @Cyberbeing @pytorchbot