[dynamo] Fix keyword argument name of all_dim #95600
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/95600
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit 9567608: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
kiszk
changed the title
ezyang
approved these changes
Feb 27, 2023
|
@pytorchbot merge -r master |
|
@pytorchbot successfully started a rebase job. Check the current status here |
|
Successfully rebased |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 1, 2023
This PR changes keyword argument name of `all_dim` function from `keeepdim` to `keepdim`. Pull Request resolved: pytorch/pytorch#95600 Approved by: https://github.com/ezyang
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 2, 2023
This PR changes keyword argument name of `all_dim` function from `keeepdim` to `keepdim`. Pull Request resolved: pytorch/pytorch#95600 Approved by: https://github.com/ezyang
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 5, 2023
This PR changes keyword argument name of `all_dim` function from `keeepdim` to `keepdim`. Pull Request resolved: pytorch/pytorch#95600 Approved by: https://github.com/ezyang
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 5, 2023
This PR changes keyword argument name of `all_dim` function from `keeepdim` to `keepdim`. Pull Request resolved: pytorch/pytorch#95600 Approved by: https://github.com/ezyang
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 27, 2023
This PR changes keyword argument name of `all_dim` function from `keeepdim` to `keepdim`. Pull Request resolved: pytorch/pytorch#95600 Approved by: https://github.com/ezyang
pruthvistony
added a commit
to ROCm/pytorch
that referenced
this pull request
May 2, 2023
This reverts commit 3beb644.
jhavukainen
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Mar 15, 2024
This PR changes keyword argument name of `all_dim` function from `keeepdim` to `keepdim`. Pull Request resolved: pytorch#95600 Approved by: https://github.com/ezyang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes keyword argument name of
all_dimfunction fromkeeepdimtokeepdim.cc @soumith @voznesenskym @yanboliang @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @desertfire