Skip to content

Conversation

@pytorch-bot
Copy link

pytorch-bot bot commented Feb 27, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/95650

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 54e5377:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Feb 27, 2023
Move things around in the effort of preparing to refactor
the code structure.

[ghstack-poisoned]


@_beartype.beartype
def _trace_into_fx_graph_via_fx_symbolic_trace(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make it a FX frontend?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will attempt in a follow up.



@_beartype.beartype
def _move_placeholder_to_front(graph_module: torch.fx.GraphModule) -> None:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some graph transforms in this file. They are good candidates for new Transform classes.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in the pass PR.

Move things around in the effort of preparing to refactor
the code structure.

[ghstack-poisoned]
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 12, 2023
Move things around in the effort of preparing to refactor
the code structure.
Pull Request resolved: pytorch/pytorch#95650
Approved by: https://github.com/titaiwangms
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 12, 2023
Move things around in the effort of preparing to refactor
the code structure.
Pull Request resolved: pytorch/pytorch#95650
Approved by: https://github.com/titaiwangms
ydwu4 added a commit to ydwu4/pytorch that referenced this pull request Mar 13, 2023
Move things around in the effort of preparing to refactor
the code structure.
Pull Request resolved: pytorch#95650
Approved by: https://github.com/titaiwangms
@facebook-github-bot facebook-github-bot deleted the gh/BowenBao/200/head branch June 8, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged module: onnx Related to torch.onnx open source release notes: onnx torch.onnx related changes that should show up in the release notes topic: improvements topic category topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants