Initial minifier smoke test + runbook #95670
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/95670
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 0a5725a: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D43415890 |
mlazos
changed the title
Summary: Pull Request resolved: pytorch#95670 Adds a manual smoke test for the minifier in fb code to use as an example for the runbook. (We already have automatic tests which should be running) See draft runbook: https://docs.google.com/document/d/18I0KYhWiYo4taC4foR2UcijJXYyEcZV4McBJQIUSSJw/edit# Test Plan: buck2 run mode/dev-nosan //caffe2/test/inductor:minifier_smoke Run displayed minifier launcher script, and it should reduce the graph from 5 to 3 nodes Differential Revision: D43415890 fbshipit-source-id: b0252fde9807a07bd4b699b1241561f2d53da60c
|
This pull request was exported from Phabricator. Differential Revision: D43415890 |
mlazos
force-pushed
the
export-D43415890
branch
from
17ab906 to
3f773c0
Compare
yanboliang
approved these changes
Feb 28, 2023
|
@mlazos has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
anijain2305
approved these changes
Feb 28, 2023
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 2, 2023
Summary: Adds a manual smoke test for the minifier in fb code to use as an example for the runbook. (We already have automatic tests which should be running) See draft runbook: https://docs.google.com/document/d/18I0KYhWiYo4taC4foR2UcijJXYyEcZV4McBJQIUSSJw/edit# Test Plan: buck2 run mode/dev-nosan //caffe2/test/inductor:minifier_smoke Run displayed minifier launcher script, and it should reduce the graph from 5 to 3 nodes Differential Revision: D43415890 Pull Request resolved: pytorch/pytorch#95670 Approved by: https://github.com/yanboliang, https://github.com/anijain2305
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 5, 2023
Summary: Adds a manual smoke test for the minifier in fb code to use as an example for the runbook. (We already have automatic tests which should be running) See draft runbook: https://docs.google.com/document/d/18I0KYhWiYo4taC4foR2UcijJXYyEcZV4McBJQIUSSJw/edit# Test Plan: buck2 run mode/dev-nosan //caffe2/test/inductor:minifier_smoke Run displayed minifier launcher script, and it should reduce the graph from 5 to 3 nodes Differential Revision: D43415890 Pull Request resolved: pytorch/pytorch#95670 Approved by: https://github.com/yanboliang, https://github.com/anijain2305
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 5, 2023
Summary: Adds a manual smoke test for the minifier in fb code to use as an example for the runbook. (We already have automatic tests which should be running) See draft runbook: https://docs.google.com/document/d/18I0KYhWiYo4taC4foR2UcijJXYyEcZV4McBJQIUSSJw/edit# Test Plan: buck2 run mode/dev-nosan //caffe2/test/inductor:minifier_smoke Run displayed minifier launcher script, and it should reduce the graph from 5 to 3 nodes Differential Revision: D43415890 Pull Request resolved: pytorch/pytorch#95670 Approved by: https://github.com/yanboliang, https://github.com/anijain2305
pruthvistony
added a commit
to ROCm/pytorch
that referenced
this pull request
May 2, 2023
This reverts commit 94bec94.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adds a manual smoke test for the minifier in fb code to use as an example for the runbook. (We already have automatic tests which should be running)
See draft runbook:
https://docs.google.com/document/d/18I0KYhWiYo4taC4foR2UcijJXYyEcZV4McBJQIUSSJw/edit#
Test Plan:
buck2 run mode/dev-nosan //caffe2/test/inductor:minifier_smoke
Run displayed minifier launcher script, and it should reduce the graph from 5 to 3 nodes
Differential Revision: D43415890
cc @soumith @voznesenskym @yanboliang @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @desertfire