Skip to content

[dtensor] fix experimental_op slice_scatter #95894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[dtensor] fix experimental_op slice_scatter #95894

wants to merge 1 commit into from

Conversation

@wanchaol
Copy link
Collaborator

@wanchaol wanchaol commented Mar 2, 2023

Test Plan: test with spmd e2e flow

Differential Revision: D43740349

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Mar 2, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 2, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/95894

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit fd701bd:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 2, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: wanchaol / name: Wanchao (30c217f5c856ae3f6170b47549d5d8c5a23a198f)

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43740349

@wanchaol
Copy link
Collaborator Author

wanchaol commented Mar 2, 2023

/easycla

fegin
fegin approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@fegin fegin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Linter errors are real.

@wanchaol
Copy link
Collaborator Author

wanchaol commented Mar 2, 2023

/easycla

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43740349

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43740349

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43740349

@facebook-github-bot
[dtensor] fix experimental_op slice_scatter (pytorch#95894)
fd701bd 
Summary: Pull Request resolved: pytorch#95894

Test Plan: test with spmd e2e flow

Reviewed By: fegin

Differential Revision: D43740349

fbshipit-source-id: 4c2966d0b1ee5a64a41b86ca32fd73468f22413e
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43740349

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 3, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 5, 2023
@cyyever
[dtensor] fix experimental_op slice_scatter (#95894)
c6f898d 
Test Plan: test with spmd e2e flow

Differential Revision: D43740349

Pull Request resolved: pytorch/pytorch#95894
Approved by: https://github.com/fegin
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 5, 2023
@cyyever
[dtensor] fix experimental_op slice_scatter (#95894)
22ec61d 
Test Plan: test with spmd e2e flow

Differential Revision: D43740349

Pull Request resolved: pytorch/pytorch#95894
Approved by: https://github.com/fegin
ydwu4 added a commit to ydwu4/pytorch that referenced this pull request Mar 13, 2023
@ydwu4
[dtensor] fix experimental_op slice_scatter (pytorch#95894)
87f834c 
Test Plan: test with spmd e2e flow

Differential Revision: D43740349

Pull Request resolved: pytorch#95894
Approved by: https://github.com/fegin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fegin fegin fegin approved these changes

@mrshenli mrshenli Awaiting requested review from mrshenli

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

@rohan-varma rohan-varma Awaiting requested review from rohan-varma

@H-Huang H-Huang Awaiting requested review from H-Huang

@awgu awgu Awaiting requested review from awgu

@kwen2501 kwen2501 Awaiting requested review from kwen2501

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wanchaol @facebook-github-bot @pytorchmergebot @fegin