-
Notifications
You must be signed in to change notification settings - Fork 25.9k
[dtensor] refactor shape/offset calculation #95923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/95923
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit e8f5548: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
fduwjj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Shape offset calculation is commonly used and extract them into a separate util [ghstack-poisoned]
Shape offset calculation is commonly used and extract them into a separate util [ghstack-poisoned]
Shape offset calculation is commonly used and extract them into a separate util [ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Shape offset calculation is commonly used and extract them into a separate util Pull Request resolved: pytorch/pytorch#95923 Approved by: https://github.com/fduwjj
Shape offset calculation is commonly used and extract them into a separate util Pull Request resolved: pytorch#95923 Approved by: https://github.com/fduwjj
Stack from ghstack (oldest at bottom):
Shape offset calculation is commonly used and extract them into a separate util