Skip to content

Conversation

@wanchaol
Copy link
Collaborator

@wanchaol wanchaol commented Mar 3, 2023

Stack from ghstack (oldest at bottom):

Shape offset calculation is commonly used and extract them into a separate util

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 3, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/95923

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e8f5548:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Contributor

@fduwjj fduwjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Shape offset calculation is commonly used and extract them into a separate util



[ghstack-poisoned]
@wanchaol wanchaol added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 3, 2023
wanchaol added 2 commits March 3, 2023 22:00
Shape offset calculation is commonly used and extract them into a separate util



[ghstack-poisoned]
Shape offset calculation is commonly used and extract them into a separate util



[ghstack-poisoned]
@wanchaol
Copy link
Collaborator Author

wanchaol commented Mar 5, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 5, 2023
Shape offset calculation is commonly used and extract them into a separate util

Pull Request resolved: pytorch/pytorch#95923
Approved by: https://github.com/fduwjj
ydwu4 added a commit to ydwu4/pytorch that referenced this pull request Mar 13, 2023
Shape offset calculation is commonly used and extract them into a separate util

Pull Request resolved: pytorch#95923
Approved by: https://github.com/fduwjj
@facebook-github-bot facebook-github-bot deleted the gh/wanchaol/271/head branch June 8, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants