Skip to content

Conversation

cyyever
Copy link
Collaborator

@cyyever cyyever commented Mar 3, 2023

These warnings are disabled to avoid long log on Windows tests. They are also disabled on CMake buildings currently.
'/wd4624': MSVC complains "destructor was implicitly defined as delete" on c10::optional and other templates
'/wd4076': "unexpected tokens following preprocessor directive - expected a newline" on some header
'/wd4068': "The compiler ignored an unrecognized [pragma]"

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 3, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/95933

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 0b88321:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@cyyever
Copy link
Collaborator Author

cyyever commented Mar 3, 2023

@pytorchbot label 'topic: not user facing'

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Mar 3, 2023
@cyyever cyyever changed the title Fix some warning 4624 on Windows Disable more warnings on Windows CI test Mar 3, 2023
@ezyang
Copy link
Contributor

ezyang commented Mar 3, 2023

no action needed here, but I often find it pretty useful to add comments saying what the particular error being disabled is (that being said, these are relatively simple to google)

@ezyang
Copy link
Contributor

ezyang commented Mar 3, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 3, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@cyyever
Copy link
Collaborator Author

cyyever commented Mar 3, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled. If you believe this is a mistake,then you can re trigger it through pytorch-bot.

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

cyyever added a commit to cyyever/pytorch_private that referenced this pull request Mar 5, 2023
These warnings are disabled to avoid long log on Windows tests. They are also disabled on CMake buildings currently.
'/wd4624': MSVC complains  "destructor was implicitly defined as delete" on c10::optional and other templates
'/wd4076': "unexpected tokens following preprocessor directive - expected a newline" on some header
'/wd4068': "The compiler ignored an unrecognized [pragma]"

Pull Request resolved: pytorch/pytorch#95933
Approved by: https://github.com/ezyang
cyyever added a commit to cyyever/pytorch_private that referenced this pull request Mar 5, 2023
These warnings are disabled to avoid long log on Windows tests. They are also disabled on CMake buildings currently.
'/wd4624': MSVC complains  "destructor was implicitly defined as delete" on c10::optional and other templates
'/wd4076': "unexpected tokens following preprocessor directive - expected a newline" on some header
'/wd4068': "The compiler ignored an unrecognized [pragma]"

Pull Request resolved: pytorch/pytorch#95933
Approved by: https://github.com/ezyang
ydwu4 added a commit to ydwu4/pytorch that referenced this pull request Mar 13, 2023
These warnings are disabled to avoid long log on Windows tests. They are also disabled on CMake buildings currently.
'/wd4624': MSVC complains  "destructor was implicitly defined as delete" on c10::optional and other templates
'/wd4076': "unexpected tokens following preprocessor directive - expected a newline" on some header
'/wd4068': "The compiler ignored an unrecognized [pragma]"

Pull Request resolved: pytorch#95933
Approved by: https://github.com/ezyang
@cyyever cyyever deleted the wd4624 branch June 3, 2023 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants