Promote "Skipping frame" message to INFO log level #95968
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, when you skip frame because of a graph break, at INFO logging level all you see is: ``` [INFO] Step 1: torchdynamo start tracing run_n_iterations [INFO] Step 1: torchdynamo start tracing forward_pass ``` With this promotion, you now see: ``` [INFO] Step 1: torchdynamo start tracing run_n_iterations [INFO] Skipping frame because there is a graph break in a for/while loop [INFO] Step 1: torchdynamo start tracing forward_pass ``` This is MUCH more useful, while only adding a single log message per already existing INFO log message. Signed-off-by: Edward Z. Yang <ezyang@meta.com> [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/95968
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit dc2ab4f: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ezyang
added a commit
that referenced
this pull request
Mar 3, 2023
Without this, when you skip frame because of a graph break, at INFO logging level all you see is: ``` [INFO] Step 1: torchdynamo start tracing run_n_iterations [INFO] Step 1: torchdynamo start tracing forward_pass ``` With this promotion, you now see: ``` [INFO] Step 1: torchdynamo start tracing run_n_iterations [INFO] Skipping frame because there is a graph break in a for/while loop [INFO] Step 1: torchdynamo start tracing forward_pass ``` This is MUCH more useful, while only adding a single log message per already existing INFO log message. Signed-off-by: Edward Z. Yang <ezyangmeta.com> ghstack-source-id: d838473 Pull Request resolved: #95968
github-actions
bot
requested review from
Chillee,
SherlockNoMad,
albanD,
antoniojkim,
bdhirsh,
jbschlosser,
miladm,
voznesenskym and
wconstab
albanD
approved these changes
Mar 6, 2023
|
@pytorchbot merge -r master |
|
@pytorchbot successfully started a rebase job. Check the current status here |
Without this, when you skip frame because of a graph break, at INFO logging level all you see is: ``` [INFO] Step 1: torchdynamo start tracing run_n_iterations [INFO] Step 1: torchdynamo start tracing forward_pass ``` With this promotion, you now see: ``` [INFO] Step 1: torchdynamo start tracing run_n_iterations [INFO] Skipping frame because there is a graph break in a for/while loop [INFO] Step 1: torchdynamo start tracing forward_pass ``` This is MUCH more useful, while only adding a single log message per already existing INFO log message. Signed-off-by: Edward Z. Yang <ezyangmeta.com> cc soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
|
Successfully rebased |
pytorchmergebot
pushed a commit
that referenced
this pull request
Mar 6, 2023
Without this, when you skip frame because of a graph break, at INFO logging level all you see is: ``` [INFO] Step 1: torchdynamo start tracing run_n_iterations [INFO] Step 1: torchdynamo start tracing forward_pass ``` With this promotion, you now see: ``` [INFO] Step 1: torchdynamo start tracing run_n_iterations [INFO] Skipping frame because there is a graph break in a for/while loop [INFO] Step 1: torchdynamo start tracing forward_pass ``` This is MUCH more useful, while only adding a single log message per already existing INFO log message. Signed-off-by: Edward Z. Yang <ezyangmeta.com> ghstack-source-id: cf7739c Pull Request resolved: #95968
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 12, 2023
Without this, when you skip frame because of a graph break, at INFO logging level all you see is: ``` [INFO] Step 1: torchdynamo start tracing run_n_iterations [INFO] Step 1: torchdynamo start tracing forward_pass ``` With this promotion, you now see: ``` [INFO] Step 1: torchdynamo start tracing run_n_iterations [INFO] Skipping frame because there is a graph break in a for/while loop [INFO] Step 1: torchdynamo start tracing forward_pass ``` This is MUCH more useful, while only adding a single log message per already existing INFO log message. Signed-off-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: pytorch/pytorch#95968 Approved by: https://github.com/albanD, https://github.com/janeyx99
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 12, 2023
Without this, when you skip frame because of a graph break, at INFO logging level all you see is: ``` [INFO] Step 1: torchdynamo start tracing run_n_iterations [INFO] Step 1: torchdynamo start tracing forward_pass ``` With this promotion, you now see: ``` [INFO] Step 1: torchdynamo start tracing run_n_iterations [INFO] Skipping frame because there is a graph break in a for/while loop [INFO] Step 1: torchdynamo start tracing forward_pass ``` This is MUCH more useful, while only adding a single log message per already existing INFO log message. Signed-off-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: pytorch/pytorch#95968 Approved by: https://github.com/albanD, https://github.com/janeyx99
ydwu4
added a commit
to ydwu4/pytorch
that referenced
this pull request
Mar 13, 2023
Without this, when you skip frame because of a graph break, at INFO logging level all you see is: ``` [INFO] Step 1: torchdynamo start tracing run_n_iterations [INFO] Step 1: torchdynamo start tracing forward_pass ``` With this promotion, you now see: ``` [INFO] Step 1: torchdynamo start tracing run_n_iterations [INFO] Skipping frame because there is a graph break in a for/while loop [INFO] Step 1: torchdynamo start tracing forward_pass ``` This is MUCH more useful, while only adding a single log message per already existing INFO log message. Signed-off-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: pytorch#95968 Approved by: https://github.com/albanD, https://github.com/janeyx99
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Without this, when you skip frame because of a graph break, at INFO logging level all you see is:
With this promotion, you now see:
This is MUCH more useful, while only adding a single log message per
already existing INFO log message.
Signed-off-by: Edward Z. Yang ezyang@meta.com
cc @soumith @voznesenskym @yanboliang @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @desertfire