QoL improvements for torch.testing.make_tensor #96125
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/96125
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 FailuresAs of commit eaa1141: NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pmeier
added
module: testing
pmeier
commented
Mar 6, 2023
Per title. The major ones: - Enforce keyword only parameters for `_modify_low_high`, which takes 7 parameters. https://github.com/pytorch/pytorch/blob/28aa2efd1422e689d3a7dc6b447ca1f31bbad1c3/torch/testing/_creation.py#L147 is just impossible to comprehend without multiple trips back and forth. - Improve the error messages by including the offending values in the message I'll highlight the smaller ones inline. [ghstack-poisoned]
mruberry
reviewed
Mar 6, 2023
mruberry
reviewed
Mar 6, 2023
Per title. The major ones: - Enforce keyword only parameters for `_modify_low_high`, which takes 7 parameters. https://github.com/pytorch/pytorch/blob/28aa2efd1422e689d3a7dc6b447ca1f31bbad1c3/torch/testing/_creation.py#L147 is just impossible to comprehend without multiple trips back and forth. - Improve the error messages by including the offending values in the message I'll highlight the smaller ones inline. [ghstack-poisoned]
This was referenced Mar 8, 2023
pmeier
commented
Mar 8, 2023
| import torch | ||
|
|
||
| # Used by make_tensor for generating complex tensor. | ||
| complex_to_corresponding_float_type_map = { |
There was a problem hiding this comment.
We don't need that since torch.finfo works for complex types as well.
Comment on lines
+11
to
+15
| _INTEGRAL_TYPES = [torch.uint8, torch.int8, torch.int16, torch.int32, torch.int64] | ||
| _FLOATING_TYPES = [torch.float16, torch.bfloat16, torch.float32, torch.float64] | ||
| _COMPLEX_TYPES = [torch.complex32, torch.complex64, torch.complex128] | ||
| _BOOLEAN_OR_INTEGRAL_TYPES = [torch.bool, *_INTEGRAL_TYPES] | ||
| _FLOATING_OR_COMPLEX_TYPES = [*_FLOATING_TYPES, *_COMPLEX_TYPES] |
There was a problem hiding this comment.
Defining them here do avoid doing it over and over again inside make_tensor.
Per title. The major ones: - Enforce keyword only parameters for `_modify_low_high`, which takes 7 parameters. https://github.com/pytorch/pytorch/blob/28aa2efd1422e689d3a7dc6b447ca1f31bbad1c3/torch/testing/_creation.py#L147 is just impossible to comprehend without multiple trips back and forth. - Improve the error messages by including the offending values in the message I'll highlight the smaller ones inline. [ghstack-poisoned]
Per title. The major ones: - Enforce keyword only parameters for `_modify_low_high`, which takes 7 parameters. https://github.com/pytorch/pytorch/blob/28aa2efd1422e689d3a7dc6b447ca1f31bbad1c3/torch/testing/_creation.py#L147 is just impossible to comprehend without multiple trips back and forth. - Improve the error messages by including the offending values in the message I'll highlight the smaller ones inline. [ghstack-poisoned]
Per title. The major ones: - Enforce keyword only parameters for `_modify_low_high`, which takes 7 parameters. https://github.com/pytorch/pytorch/blob/28aa2efd1422e689d3a7dc6b447ca1f31bbad1c3/torch/testing/_creation.py#L147 is just impossible to comprehend without multiple trips back and forth. - Improve the error messages by including the offending values in the message I'll highlight the smaller ones inline. [ghstack-poisoned]
Per title. The major ones: - Enforce keyword only parameters for `_modify_low_high`, which takes 7 parameters. https://github.com/pytorch/pytorch/blob/28aa2efd1422e689d3a7dc6b447ca1f31bbad1c3/torch/testing/_creation.py#L147 is just impossible to comprehend without multiple trips back and forth. - Improve the error messages by including the offending values in the message I'll highlight the smaller ones inline. [ghstack-poisoned]
Per title. The major ones: - Enforce keyword only parameters for `_modify_low_high`, which takes 7 parameters. https://github.com/pytorch/pytorch/blob/28aa2efd1422e689d3a7dc6b447ca1f31bbad1c3/torch/testing/_creation.py#L147 is just impossible to comprehend without multiple trips back and forth. - Improve the error messages by including the offending values in the message I'll highlight the smaller ones inline. [ghstack-poisoned]
|
Rebased |
Per title. The major ones: - Enforce keyword only parameters for `_modify_low_high`, which takes 7 parameters. https://github.com/pytorch/pytorch/blob/28aa2efd1422e689d3a7dc6b447ca1f31bbad1c3/torch/testing/_creation.py#L147 is just impossible to comprehend without multiple trips back and forth. - Improve the error messages by including the offending values in the message I'll highlight the smaller ones inline. [ghstack-poisoned]
Per title. The major ones: - Enforce keyword only parameters for `_modify_low_high`, which takes 7 parameters. https://github.com/pytorch/pytorch/blob/28aa2efd1422e689d3a7dc6b447ca1f31bbad1c3/torch/testing/_creation.py#L147 is just impossible to comprehend without multiple trips back and forth. - Improve the error messages by including the offending values in the message I'll highlight the smaller ones inline. [ghstack-poisoned]
|
Rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Per title. The major ones:
_modify_low_high, which takes 7 parameters.pytorch/torch/testing/_creation.py
Line 147 in 28aa2ef
is just impossible to comprehend without multiple trips back and forth.
I'll highlight the smaller ones inline.