Changed flop formulas for flop counter to take in shapes directly #96565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/96565
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 7c539e5: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
github-actions
bot
requested review from
SherlockNoMad,
albanD,
antoniojkim,
bdhirsh,
ezyang,
jbschlosser,
miladm,
voznesenskym and
wconstab
…irectly" [ghstack-poisoned]
…irectly" [ghstack-poisoned]
drisspg
reviewed
Mar 13, 2023
| b, h, s, d = query_shape | ||
| _b2, _h2, s2, _d2 = key_shape | ||
| _b3, _h3, _s3, _d3 = grad_out_shape | ||
| assert b == _b2 == _b3 and h == _h2 == _h3 and d == _d2 == _d3 |
There was a problem hiding this comment.
V can have a different embed dim from q,k and mem efficient supports that
zdevito
approved these changes
Mar 13, 2023
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 23, 2023
…6565) Pull Request resolved: pytorch/pytorch#96565 Approved by: https://github.com/zdevito
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 27, 2023
…6565) Pull Request resolved: pytorch/pytorch#96565 Approved by: https://github.com/zdevito
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):