[Inductor] Enable Inductor to support BF16 atomic_add #96620
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/96620
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 7d82107: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
EikanWang
added
topic: not user facing
jansel
approved these changes
Mar 12, 2023
jgong5
approved these changes
Mar 13, 2023
test/inductor/test_torchinductor.py
Outdated
| union = {*cpp_vec_op_list, *diff} | ||
| self.assertTrue(set(cpp_op_list).issubset(union)) | ||
|
|
||
| def test_atomic_add(self): |
There was a problem hiding this comment.
If it is specific to bfloat16, add "bfloat16" suffix to the test function name? Otherwise, consider to make it general for other types.
cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 soumith voznesenskym penguinwu anijain2305 Guobing-Chen zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]
This was referenced Mar 13, 2023
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 23, 2023
Pull Request resolved: pytorch/pytorch#96620 Approved by: https://github.com/jansel, https://github.com/jgong5
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 27, 2023
Pull Request resolved: pytorch/pytorch#96620 Approved by: https://github.com/jansel, https://github.com/jgong5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @soumith @voznesenskym @penguinwu @anijain2305 @Guobing-Chen @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @desertfire