Default specialize_int to False #96624

ezyang · 2023-03-12T18:45:04Z

Stack from ghstack (oldest at bottom):

-> Default specialize_int to False #96624

Signed-off-by: Edward Z. Yang ezyang@meta.com

cc @soumith @voznesenskym @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @desertfire

Signed-off-by: Edward Z. Yang <ezyang@meta.com> [ghstack-poisoned]

pytorch-bot · 2023-03-12T18:45:06Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/96624

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 Failures

As of commit 28ab146:

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base ba4fb9b:

👉 Rebase onto the `viable/strict` branch to avoid these failures

cuda11.8-py3.10-gcc7-sm86 / test (inductor_torchbench, 1, 1, linux.g5.4xlarge.nvidia.gpu) (gh)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Signed-off-by: Edward Z. Yang <ezyangmeta.com> ghstack-source-id: 7da0200 Pull Request resolved: #96624

Signed-off-by: Edward Z. Yang <ezyangmeta.com> cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]

Signed-off-by: Edward Z. Yang <ezyangmeta.com> ghstack-source-id: 553b6de Pull Request resolved: #96624

janeyx99 · 2023-03-14T14:55:14Z

test/dynamo/test_dynamic_shapes.py

        (config, "dynamic_shapes", True),
        (config, "assume_static_by_default", static_default),
-        (config, "specialize_int", not unspec),
+        (config, "specialize_int", static_default),


Question: This code pairs assume_static_by_default with specialize_int; both are True or both are False (the default). Is it also conceivable to have one be True while the other False? The config in line 86 used to be assume_static_by_default = False and specialize_int = True and now means both = False.

Yes, I have reduced coverage. This is a calculated decision: assume static by default is heavily correlated with specializing ints, as these are correlated with export usage. In eager usage, we expect unspec int and not assuming static by default. There's two configs that are not tested, but I think testing them is unnecessary as we will get adequate coverage otherwise.

janeyx99

looks fine to me then

ezyang · 2023-03-14T18:35:57Z

@pytorchbot merge -f "spurious lint failure on master"

pytorchmergebot · 2023-03-14T18:37:41Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

kit1980 · 2023-03-14T19:36:19Z

Looks like this broke inductor/test_torchinductor_dynamic_shapes.py https://hud.pytorch.org/pytorch/pytorch/commit/1ac8782db244f6cd3d2fd109e3fe94500745e0dd

kit1980 · 2023-03-14T19:41:53Z

@pytorchbot revert -m "Broke inductor/test_torchinductor_dynamic_shapes.py" -c nosignal

pytorchmergebot · 2023-03-14T19:43:41Z

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot · 2023-03-14T19:43:58Z

@ezyang your PR has been successfully reverted.

This reverts commit 1ac8782. Reverted #96624 on behalf of https://github.com/kit1980 due to Broke inductor/test_torchinductor_dynamic_shapes.py

Signed-off-by: Edward Z. Yang <ezyangmeta.com> cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]

Signed-off-by: Edward Z. Yang <ezyangmeta.com> ghstack-source-id: 5c5df59 Pull Request resolved: #96624

Signed-off-by: Edward Z. Yang <ezyangmeta.com> cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]

Signed-off-by: Edward Z. Yang <ezyangmeta.com> ghstack-source-id: 22898ae Pull Request resolved: #96624

Signed-off-by: Edward Z. Yang <ezyangmeta.com> cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]

ezyang · 2023-03-15T13:12:01Z

@pytorchbot merge

Signed-off-by: Edward Z. Yang <ezyangmeta.com> ghstack-source-id: dbcbba8 Pull Request resolved: #96624

pytorchmergebot · 2023-03-15T13:16:00Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2023-03-15T16:54:32Z

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

pull / win-vs2019-cpu-py3 / test (default, 2, 2, windows.4xlarge)

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

ezyang · 2023-03-16T02:52:27Z

@pytorchbot merge -f "failures look unrelated"

pytorchmergebot · 2023-03-16T02:54:13Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Signed-off-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: pytorch/pytorch#96624 Approved by: https://github.com/janeyx99

This reverts commit 1ac8782. Reverted pytorch/pytorch#96624 on behalf of https://github.com/kit1980 due to Broke inductor/test_torchinductor_dynamic_shapes.py

Signed-off-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: pytorch/pytorch#96624 Approved by: https://github.com/janeyx99

This reverts commit 1ac8782. Reverted pytorch/pytorch#96624 on behalf of https://github.com/kit1980 due to Broke inductor/test_torchinductor_dynamic_shapes.py

Signed-off-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: pytorch/pytorch#96624 Approved by: https://github.com/janeyx99

Default specialize_int to False

85a1137

Signed-off-by: Edward Z. Yang <ezyang@meta.com> [ghstack-poisoned]

ezyang added a commit that referenced this pull request Mar 12, 2023

Default specialize_int to False

86192cb

Signed-off-by: Edward Z. Yang <ezyangmeta.com> ghstack-source-id: 7da0200 Pull Request resolved: #96624

github-actions bot requested review from albanD, antoniojkim and bdhirsh March 12, 2023 18:45

github-actions bot added ciflow/inductor module: dynamo labels Mar 12, 2023

github-actions bot requested a review from Chillee March 12, 2023 18:45

github-actions bot added the module: inductor label Mar 12, 2023

github-actions bot requested review from SherlockNoMad, jbschlosser, miladm, voznesenskym and wconstab March 12, 2023 18:45

albanD removed their request for review March 13, 2023 14:20

Update on "Default specialize_int to False"

d97987c

Signed-off-by: Edward Z. Yang <ezyangmeta.com> cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]

ezyang added a commit that referenced this pull request Mar 13, 2023

Default specialize_int to False

2476db5

Signed-off-by: Edward Z. Yang <ezyangmeta.com> ghstack-source-id: 553b6de Pull Request resolved: #96624

ezyang added ciflow/trunk Trigger trunk jobs on your pull request release notes: composability release notes category topic: new features topic category labels Mar 13, 2023

janeyx99 reviewed Mar 14, 2023

View reviewed changes

janeyx99 approved these changes Mar 14, 2023

View reviewed changes

pytorchmergebot added the Merged label Mar 14, 2023

pytorchmergebot closed this in 1ac8782 Mar 14, 2023

pytorchmergebot added the Reverted label Mar 14, 2023

pytorchmergebot added a commit that referenced this pull request Mar 14, 2023

Revert "Default specialize_int to False (#96624)"

ba4fb9b

This reverts commit 1ac8782. Reverted #96624 on behalf of https://github.com/kit1980 due to Broke inductor/test_torchinductor_dynamic_shapes.py

ezyang reopened this Mar 14, 2023

github-actions bot requested a review from albanD March 14, 2023 19:59

Update on "Default specialize_int to False"

d7b2f13

Signed-off-by: Edward Z. Yang <ezyangmeta.com> cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]

ezyang added a commit that referenced this pull request Mar 14, 2023

Default specialize_int to False

7ad992e

Signed-off-by: Edward Z. Yang <ezyangmeta.com> ghstack-source-id: 5c5df59 Pull Request resolved: #96624

ezyang added the keep-going Don't stop on first failure, keep running tests until the end label Mar 15, 2023

Update on "Default specialize_int to False"

fe3c664

Signed-off-by: Edward Z. Yang <ezyangmeta.com> cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]

ezyang added a commit that referenced this pull request Mar 15, 2023

Default specialize_int to False

88313b1

Signed-off-by: Edward Z. Yang <ezyangmeta.com> ghstack-source-id: 22898ae Pull Request resolved: #96624

Update on "Default specialize_int to False"

28ab146

Signed-off-by: Edward Z. Yang <ezyangmeta.com> cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]

ezyang added a commit that referenced this pull request Mar 15, 2023

Default specialize_int to False

62b23b4

Signed-off-by: Edward Z. Yang <ezyangmeta.com> ghstack-source-id: dbcbba8 Pull Request resolved: #96624

albanD removed their request for review March 15, 2023 14:46

pytorchmergebot closed this in 3606f59 Mar 16, 2023

cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 23, 2023

Default specialize_int to False (#96624)

ad4caa0

Signed-off-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: pytorch/pytorch#96624 Approved by: https://github.com/janeyx99

cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 23, 2023

Default specialize_int to False (#96624)

ad7ca71

Signed-off-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: pytorch/pytorch#96624 Approved by: https://github.com/janeyx99

cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 27, 2023

Default specialize_int to False (#96624)

7a3f650

Signed-off-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: pytorch/pytorch#96624 Approved by: https://github.com/janeyx99

cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 27, 2023

Default specialize_int to False (#96624)

4420c54

Signed-off-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: pytorch/pytorch#96624 Approved by: https://github.com/janeyx99

facebook-github-bot deleted the gh/ezyang/1903/head branch June 8, 2023 16:55

Default specialize_int to False #96624

Default specialize_int to False #96624

Uh oh!

Conversation

ezyang commented Mar 12, 2023 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Mar 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/96624

❌ 3 Failures

Uh oh!

janeyx99 Mar 14, 2023

Choose a reason for hiding this comment

Uh oh!

ezyang Mar 14, 2023

Choose a reason for hiding this comment

Uh oh!

janeyx99 left a comment

Choose a reason for hiding this comment

Uh oh!

ezyang commented Mar 14, 2023

Uh oh!

pytorchmergebot commented Mar 14, 2023

Merge started

Uh oh!

kit1980 commented Mar 14, 2023

Uh oh!

kit1980 commented Mar 14, 2023

Uh oh!

pytorchmergebot commented Mar 14, 2023

Uh oh!

pytorchmergebot commented Mar 14, 2023

Uh oh!

ezyang commented Mar 15, 2023

Uh oh!

pytorchmergebot commented Mar 15, 2023

Merge started

Uh oh!

pytorchmergebot commented Mar 15, 2023

Merge failed

Uh oh!

ezyang commented Mar 16, 2023

Uh oh!

pytorchmergebot commented Mar 16, 2023

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ezyang commented Mar 12, 2023 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented Mar 12, 2023 •

edited

Loading