Add merge_rule for "functorch" module #96657
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR enables our non-meta contributors to be able to approve "functorch" PRs without intervention from meta contributors. A PR is deemed a "functorch" PR if it matches one of the patterns in merge_rules.yaml. These patterns are definitely not exhaustive (we modify core pytorch pieces quite often), but should be a good starting point. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/96657
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 10b36a4: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
cc @kshitij12345 @srossross when this PR gets merged, you folks will be able to approve (and merge) functorch PRs without needing someone from meta also approve the PR. |
This PR enables our non-meta contributors to be able to approve "functorch" PRs without intervention from meta contributors. A PR is deemed a "functorch" PR if it matches one of the patterns in merge_rules.yaml. These patterns are definitely not exhaustive (we modify core pytorch pieces quite often), but should be a good starting point. [ghstack-poisoned]
zou3519
added a commit
that referenced
this pull request
Mar 13, 2023
This PR enables our non-meta contributors to be able to approve "functorch" PRs without intervention from meta contributors. A PR is deemed a "functorch" PR if it matches one of the patterns in merge_rules.yaml. These patterns are definitely not exhaustive (we modify core pytorch pieces quite often), but should be a good starting point. ghstack-source-id: d7e4ede Pull Request resolved: #96657
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 23, 2023
This PR enables our non-meta contributors to be able to approve "functorch" PRs without intervention from meta contributors. A PR is deemed a "functorch" PR if it matches one of the patterns in merge_rules.yaml. These patterns are definitely not exhaustive (we modify core pytorch pieces quite often), but should be a good starting point. Pull Request resolved: pytorch/pytorch#96657 Approved by: https://github.com/albanD
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 27, 2023
This PR enables our non-meta contributors to be able to approve "functorch" PRs without intervention from meta contributors. A PR is deemed a "functorch" PR if it matches one of the patterns in merge_rules.yaml. These patterns are definitely not exhaustive (we modify core pytorch pieces quite often), but should be a good starting point. Pull Request resolved: pytorch/pytorch#96657 Approved by: https://github.com/albanD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This PR enables our non-meta contributors to be able to approve
"functorch" PRs without intervention from meta contributors.
A PR is deemed a "functorch" PR if it matches one of the patterns in
merge_rules.yaml. These patterns are definitely not exhaustive
(we modify core pytorch pieces quite often), but should be a good starting
point.