[PyTorch] Second try: use c10::FastMap for memoizing in Pickler #96688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These maps don't rely on reference stability, so FastMap should be fine. First try (#96360) was reverted because it broke internal tests. Differential Revision: [D43995796](https://our.internmc.facebook.com/intern/diff/D43995796/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D43995796/)! [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/96688
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 92b8faf: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
swolchok
added a commit
that referenced
this pull request
Mar 13, 2023
These maps don't rely on reference stability, so FastMap should be fine. First try (#96360) was reverted because it broke internal tests. Differential Revision: [D43995796](https://our.internmc.facebook.com/intern/diff/D43995796/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D43995796/)! ghstack-source-id: 182737118 Pull Request resolved: #96688
…ckler" These maps don't rely on reference stability, so FastMap should be fine. First try (#96360) was reverted because it broke internal tests. Differential Revision: [D43995796](https://our.internmc.facebook.com/intern/diff/D43995796/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D43995796/)! [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Mar 21, 2023
Pull Request resolved: #96688 These maps don't rely on reference stability, so FastMap should be fine. First try (#96360) was reverted because it broke internal tests. ghstack-source-id: 183500502 Differential Revision: [D43995796](https://our.internmc.facebook.com/intern/diff/D43995796/)
malfet
approved these changes
Mar 23, 2023
…ckler" These maps don't rely on reference stability, so FastMap should be fine. First try (#96360) was reverted because it broke internal tests. Differential Revision: [D43995796](https://our.internmc.facebook.com/intern/diff/D43995796/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D43995796/)! [ghstack-poisoned]
…ckler" These maps don't rely on reference stability, so FastMap should be fine. First try (#96360) was reverted because it broke internal tests. Differential Revision: [D43995796](https://our.internmc.facebook.com/intern/diff/D43995796/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D43995796/)! [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Mar 27, 2023
Pull Request resolved: #96688 These maps don't rely on reference stability, so FastMap should be fine. First try (#96360) was reverted because it broke internal tests. ghstack-source-id: 184199588 Differential Revision: [D43995796](https://our.internmc.facebook.com/intern/diff/D43995796/)
|
internal stuff looks to be in a reasonable state, merging |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
These maps don't rely on reference stability, so FastMap should be fine.
First try (#96360) was reverted because it broke internal tests.
Differential Revision: D43995796
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!