Skip to content

Back out "Add _int_mm to expose cuBLAS int8@int8 -> int32 matmul (#94339)" #96885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Back out "Add _int_mm to expose cuBLAS int8@int8 -> int32 matmul (#94339)" #96885

wants to merge 3 commits into from

Conversation

cpuhrsch
Copy link
Contributor

@cpuhrsch cpuhrsch commented Mar 15, 2023 •
edited by pytorch-bot bot
Loading

@cpuhrsch @facebook-github-bot
Back out "Add _int_mm to expose cuBLAS int8@int8 -> int32 matmul (pyt…
757eff6 
…orch#94339)"

Summary:
Backing out D43643791
Add _int_mm to expose cuBLAS int8@int8 -> int32 matmul (pytorch#94339)

Test Plan: CI

Differential Revision: D44107160

fbshipit-source-id: ec7509c34e7f9e40ea001faaf11d65664345db89
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 15, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/96885

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 1623cb9:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: linalg_frontend release notes category label Mar 15, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44107160

@cpuhrsch cpuhrsch requested review from drisspg and removed request for IvanYashchuk, lezcano and nikitaved March 15, 2023 20:49
drisspg
drisspg approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@drisspg drisspg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔨

@facebook-github-bot
Copy link
Contributor

@cpuhrsch has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cpuhrsch
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 15, 2023
@cpuhrsch cpuhrsch added topic: not user facing topic category and removed release notes: linalg_frontend release notes category module: inductor labels Mar 15, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@facebook-github-bot
Copy link
Contributor

@cpuhrsch has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cpuhrsch
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 23, 2023
@cpuhrsch @cyyever
Back out "Add _int_mm to expose cuBLAS int8@int8 -> int32 matmul (#94…
f894875 
…339)" (#96885)

Summary:
Backing out  _int_mm to expose cuBLAS int8@int8 -> int32 matmul (#94339)

Test Plan: CI

Pull Request resolved: pytorch/pytorch#96885
Approved by: https://github.com/drisspg
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 27, 2023
@cpuhrsch @cyyever
Back out "Add _int_mm to expose cuBLAS int8@int8 -> int32 matmul (#94…
a8cacc0 
…339)" (#96885)

Summary:
Backing out  _int_mm to expose cuBLAS int8@int8 -> int32 matmul (#94339)

Test Plan: CI

Pull Request resolved: pytorch/pytorch#96885
Approved by: https://github.com/drisspg
@fxmarty
Copy link

fxmarty commented Jun 12, 2023

@cpuhrsch Being curious: why?

@cpuhrsch
Copy link
Contributor Author

@fxmarty - This has since been landed again via #96685

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drisspg drisspg drisspg approved these changes

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cpuhrsch @facebook-github-bot @pytorchmergebot @fxmarty @drisspg