Skip to content

[NCCL] Cleanup NCCL-no-record streams, move to TORCH_NCCL_AVOID_RECORD_STREAMS #97053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[NCCL] Cleanup NCCL-no-record streams, move to TORCH_NCCL_AVOID_RECORD_STREAMS #97053

wants to merge 1 commit into from

Conversation

eqy
Copy link
Collaborator

@eqy eqy commented Mar 17, 2023

Cleanup of #89880 including moving environment variable to TORCH_* prefix and a warning condition fix.

CC @ptrblck @kwen2501

@eqy eqy added open source module: c10d Issues/PRs related to collective communications and process groups ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category labels Mar 17, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 17, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/97053

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 680825f:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@cpuhrsch cpuhrsch added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Mar 20, 2023
kwen2501
kwen2501 approved these changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@kwen2501 kwen2501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@eqy
Copy link
Collaborator Author

eqy commented Mar 24, 2023

@pytorchmergebot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased nccl_record_cleanup onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout nccl_record_cleanup && git pull --rebase)

@eqy
Copy link
Collaborator Author

eqy commented Mar 25, 2023

@pytorchmergebot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kwen2501 kwen2501 kwen2501 approved these changes

@mrshenli mrshenli Awaiting requested review from mrshenli

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

@rohan-varma rohan-varma Awaiting requested review from rohan-varma

@H-Huang H-Huang Awaiting requested review from H-Huang

@awgu awgu Awaiting requested review from awgu

@wanchaol wanchaol Awaiting requested review from wanchaol

@fegin fegin Awaiting requested review from fegin

@kiukchung kiukchung Awaiting requested review from kiukchung

@d4l3k d4l3k Awaiting requested review from d4l3k

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: c10d Issues/PRs related to collective communications and process groups open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eqy @pytorchmergebot @kwen2501 @cpuhrsch