Checking for nullptr in get_model_bytecode_version #97149

mmigdal-nv · 2023-03-20T13:13:14Z

One-liner commit to check that the ptr is not null. Just had test_jit that had a segfault there.

pytorch-bot · 2023-03-20T13:13:17Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/97149

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b6c8f61:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

linux-foundation-easycla · 2023-03-20T13:13:18Z

The committers listed above are authorized under a signed CLA.

✅ login: mmigdal-nv / name: Michel Migdal (8dd4bf4161e7c0fbba390afcacc00b3ce1dfbca0)

kit1980 · 2023-04-27T08:06:12Z

@pytorchbot merge -r

pytorchmergebot · 2023-04-27T08:08:15Z

@pytorchbot successfully started a rebase job. Check the current status here

pytorchmergebot · 2023-04-27T08:08:19Z

Rebase failed due to Command git -C /home/runner/work/pytorch/pytorch push -f https://github.com/mmigdal-nv/pytorch.git pull/97149/head:check_null_ptr returned non-zero exit code 128

remote: Permission to mmigdal-nv/pytorch.git denied to pytorchmergebot.
fatal: unable to access 'https://github.com/mmigdal-nv/pytorch.git/': The requested URL returned error: 403

Raised by https://github.com/pytorch/pytorch/actions/runs/4817458601

pytorchmergebot · 2023-04-27T08:09:29Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2023-04-27T08:09:30Z

Merge failed

Reason: This PR is too stale; the last push date was more than 3 days ago. Please rebase and try again. You can rebase and merge by leaving the following comment on this PR:
@pytorchbot merge -r
Or just rebase by leaving @pytorchbot rebase comment

Details for Dev Infra team

Raised by workflow job

mmigdal-nv · 2023-04-27T12:47:08Z

@kit1980 rebased the PR

kit1980 · 2023-05-16T18:21:51Z

@pytorchbot merge -r

pytorchmergebot · 2023-05-16T18:23:59Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot · 2023-05-16T18:24:02Z

Rebase failed due to Command git -C /home/runner/work/pytorch/pytorch push -f https://github.com/mmigdal-nv/pytorch.git pull/97149/head:check_null_ptr returned non-zero exit code 128

remote: Permission to mmigdal-nv/pytorch.git denied to pytorchmergebot.
fatal: unable to access 'https://github.com/mmigdal-nv/pytorch.git/': The requested URL returned error: 403

Raised by https://github.com/pytorch/pytorch/actions/runs/4995395856

pytorchmergebot · 2023-05-16T18:25:09Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2023-05-16T18:25:10Z

Merge failed

Reason: This PR is too stale; the last push date was more than 3 days ago. Please rebase and try again. You can rebase and merge by leaving the following comment on this PR:
@pytorchbot merge -r
Or just rebase by leaving @pytorchbot rebase comment

Details for Dev Infra team

Raised by workflow job

kit1980 · 2023-06-13T22:00:03Z

@pytorchbot merge -r

pytorchmergebot · 2023-06-13T22:03:32Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot · 2023-06-13T22:03:35Z

Rebase failed due to Command git -C /home/runner/work/pytorch/pytorch push -f https://github.com/mmigdal-nv/pytorch.git pull/97149/head:check_null_ptr returned non-zero exit code 128

remote: Permission to mmigdal-nv/pytorch.git denied to pytorchmergebot.
fatal: unable to access 'https://github.com/mmigdal-nv/pytorch.git/': The requested URL returned error: 403

Raised by https://github.com/pytorch/pytorch/actions/runs/5260753919

pytorchmergebot · 2023-06-13T22:04:42Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2023-06-13T22:04:43Z

Merge failed

Reason: This PR is too stale; the last push date was more than 3 days ago. Please rebase and try again. You can rebase and merge by leaving the following comment on this PR:
@pytorchbot merge -r
Or just rebase by leaving @pytorchbot rebase comment

Details for Dev Infra team

Raised by workflow job

kit1980 · 2023-06-13T23:52:51Z

@pytorchbot merge -f "Small low risk change, should be fine without rebase"

pytorchmergebot · 2023-06-13T23:54:41Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorch-bot bot added the release notes: mobile release notes category label Mar 20, 2023

pytorchbot added the open source label Mar 20, 2023

mmigdal-nv marked this pull request as ready for review March 22, 2023 18:12

drisspg added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Mar 28, 2023

kit1980 approved these changes Apr 27, 2023

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 27, 2023

pytorchmergebot added the merging label Apr 27, 2023

Checking for nullptr in get_model_bytecode_version

b6c8f61

mmigdal-nv force-pushed the check_null_ptr branch from 8dd4bf4 to b6c8f61 Compare April 27, 2023 12:46

mmigdal-nv requested a review from kit1980 April 28, 2023 18:08

kit1980 approved these changes May 16, 2023

View reviewed changes

pytorchmergebot removed the merging label May 16, 2023

pytorchmergebot added the merging label Jun 13, 2023

pytorchmergebot removed the merging label Jun 13, 2023

pytorchmergebot added the merging label Jun 13, 2023

pytorchmergebot added Merged and removed merging labels Jun 13, 2023

pytorchmergebot closed this in 6cc0f1c Jun 13, 2023

Checking for nullptr in get_model_bytecode_version #97149

Checking for nullptr in get_model_bytecode_version #97149

Uh oh!

Conversation

mmigdal-nv commented Mar 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Mar 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/97149

✅ No Failures

Uh oh!

linux-foundation-easycla bot commented Mar 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kit1980 commented Apr 27, 2023

Uh oh!

pytorchmergebot commented Apr 27, 2023

Uh oh!

pytorchmergebot commented Apr 27, 2023

Uh oh!

pytorchmergebot commented Apr 27, 2023

Merge started

Uh oh!

pytorchmergebot commented Apr 27, 2023

Merge failed

Uh oh!

mmigdal-nv commented Apr 27, 2023

Uh oh!

kit1980 commented May 16, 2023

Uh oh!

pytorchmergebot commented May 16, 2023

Uh oh!

pytorchmergebot commented May 16, 2023

Uh oh!

pytorchmergebot commented May 16, 2023

Merge started

Uh oh!

pytorchmergebot commented May 16, 2023

Merge failed

Uh oh!

kit1980 commented Jun 13, 2023

Uh oh!

pytorchmergebot commented Jun 13, 2023

Uh oh!

pytorchmergebot commented Jun 13, 2023

Uh oh!

pytorchmergebot commented Jun 13, 2023

Merge started

Uh oh!

pytorchmergebot commented Jun 13, 2023

Merge failed

Uh oh!

kit1980 commented Jun 13, 2023

Uh oh!

pytorchmergebot commented Jun 13, 2023

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mmigdal-nv commented Mar 20, 2023 •

edited

Loading

pytorch-bot bot commented Mar 20, 2023 •

edited

Loading

linux-foundation-easycla bot commented Mar 20, 2023 •

edited

Loading