Skip to content

Conversation

@weiwangmeta
Copy link
Contributor

Currently old commits' jobs are not cancelled: https://github.com/pytorch/pytorch/actions/workflows/inductor-perf-compare.yml
This PR tries to fix the concurrency rule so that when new commit is pushed, old job gets cancelled immediately.

@weiwangmeta weiwangmeta requested a review from a team as a code owner March 20, 2023 23:13
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Mar 20, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 20, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/97197

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a729fa4:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@weiwangmeta
Copy link
Contributor Author

@pytorchbot merge -f "lint is green plus it should only help reduce queuing of inductor-perf-compare job"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@weiwangmeta weiwangmeta deleted the weiwangmeta/fix_inductor-perf-compare_concurrency_rule branch March 20, 2023 23:35
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 23, 2023
…are job (#97197)

Currently old commits' jobs are not cancelled: https://github.com/pytorch/pytorch/actions/workflows/inductor-perf-compare.yml
This PR tries to fix the concurrency rule so that when new commit is pushed, old job gets cancelled immediately.
Pull Request resolved: pytorch/pytorch#97197
Approved by: https://github.com/atalman
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 27, 2023
…are job (#97197)

Currently old commits' jobs are not cancelled: https://github.com/pytorch/pytorch/actions/workflows/inductor-perf-compare.yml
This PR tries to fix the concurrency rule so that when new commit is pushed, old job gets cancelled immediately.
Pull Request resolved: pytorch/pytorch#97197
Approved by: https://github.com/atalman
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants